WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #25239


Ignore:
Timestamp:
09/06/2013 02:17:50 PM (7 years ago)
Author:
SergeyBiryukov
Comment:

Related: #16805

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25239 – Description

    initial v1  
    11For quite some time I have been having an issue with my comment notifications. The From address has been wordpress@_. I haven't paid much attention to this, but I had some spare time and decided to pursue the issue. Here it is...
    22
    3 I am running WPMS w/ domains (latest stable) with Nginx and PHP5-FPM. In WordPress the comment notifications from email addresses are being generated using $_SERVER['SERVER_NAME'] to get the current site's domain name.
     3I am running WPMS w/ domains (latest stable) with Nginx and PHP5-FPM. In WordPress the comment notifications from email addresses are being generated using `$_SERVER['SERVER_NAME']` to get the current site's domain name.
    44
    55e.g.
     
    4444}}}
    4545
    46 Thus, $_SERVER['SERVER_NAME'] is outputting "_" (underscore).
     46Thus, `$_SERVER['SERVER_NAME']` is outputting "_" (underscore).
    4747
    48 I propose we move away from $_SERVER['SERVER_NAME'] when generating the from email addresses and use the available $current_site global object which stores the domain variable ($current_site->domain). I have implemented this change on my own site and have included the patch here.
     48I propose we move away from `$_SERVER['SERVER_NAME']` when generating the from email addresses and use the available $current_site global object which stores the domain variable ($current_site->domain). I have implemented this change on my own site and have included the patch here.
    4949
    5050In the meantime, anyone else facing this problem can change their fastcgi_param to $host instead of $server_name. In my opinion, not the best solution, but it works for now.