Opened 19 years ago
Closed 19 years ago
#2524 closed defect (bug) (fixed)
$table* global variables sheduled for deletion
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.1 | Priority: | lowest |
Severity: | trivial | Version: | 2.0.1 |
Component: | Administration | Keywords: | |
Focuses: | Cc: |
Description
The $table* ($tableposts, $tablecomments) etc global variables have been marked for imminent deletion in the code for something like 18 months now. Target 2.1, or are there still enough ignorant plugin develeopers using them to warrant keeping them for a while longer?
Also, we're currently using $table_prefix variable in core code... shouldn't we be using $wpdb->table_prefix?
Attachments (2)
Change History (9)
#2
@
19 years ago
- Milestone set to 2.1
- Owner changed from anonymous to markjaquith
- Status changed from new to assigned
- Version changed from 1.2 to 2.0.1
I'm making a patch for $table_prefix now
#3
@
19 years ago
Pros:
- Makes things neater
- Forces plugins to have better code
- Reduce our symbol space
Cons:
- Negligible speed/memory etc. benefits (I'd wager)
- May break plugins
+1. These have been around so long that any plugins using them are so decrepid they probably break on some other major change as well.
#5
@
19 years ago
It may be that no matter how long we wait, people will still use these. Usage may be as low now as it's ever going to be. And yeah, David is right... anyone still using these is likely still using $user_level and $single instead of is_single() and a whole host of other things that have been deprecated.
We should definitely use the wpdb table prefix in core. I think we need to sample some plugins to see how widespread table* may be.