WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#25242 closed defect (bug) (fixed)

Provide correct multisite test information in bootstrap.php

Reported by: jeremyfelt Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: Unit Tests Keywords: has-patch commit
Focuses: Cc:

Description

tests/phpunit/includes/bootstrap.php current provides instructions to use phpunit -c multisite.xml to run multisite unit tests. As of [25156], things were modified quite a bit and this no longer works.

Patch accounts for the new location of multisite.xml and the WP_TESTS_MULTISITE constant.

Attachments (1)

25242.diff (582 bytes) - added by jeremyfelt 7 months ago.

Download all attachments as: .zip

Change History (7)

jeremyfelt7 months ago

comment:1 SergeyBiryukov7 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.7

comment:2 nacin7 months ago

Adding a reference to the constant pushes this from under 80 characters wide to more than 130.

comment:3 jeremyfelt7 months ago

Running as single site... To run multisite, use -c tests/phpunit/multisite.xml is 78, should we just go with that and leave it up to the reader to find the constant?

comment:4 follow-up: SergeyBiryukov7 months ago

Perhaps multisite.xml should just be copied to the root directory instead?

comment:5 in reply to: ↑ 4 nacin7 months ago

Replying to SergeyBiryukov:

Perhaps multisite.xml should just be copied to the root directory instead?

I don't think that is necessary, at least for the moment. Also, we might end up with new configuration files or test suites for running ajax tests.

comment:6 nacin7 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25415:

Test framework: Update path to multisite.xml.

props jeremyfelt.
fixes #25242.

Note: See TracTickets for help on using tickets.