Make WordPress Core

Opened 11 years ago

Closed 8 years ago

#25244 closed enhancement (duplicate)

Unminified versions of MediaElement.js and MediaElementPlayer not in core

Reported by: ericlewis's profile ericlewis Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: External Libraries Keywords:
Focuses: Cc:


Not sure how this fits into the new Grunt build process so I'll leave this to the big boys/girls.

Change History (14)

#1 @ericlewis
11 years ago

Also mediaelementplayer.min.css

#2 follow-up: @ocean90
11 years ago

  • Component changed from Media to External Libraries
  • Keywords close added

We usually doesn't include the unminified versions of external libraries in core. Why should it be included?

#3 in reply to: ↑ 2 @ericlewis
11 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Including unminified versions would allow developers to read the original JS/CSS source without leaving their development environment. I was looking for it in this case to copy, paste, and override media element's CSS. Also, If SCRIPT_DEBUG loaded them it would open up the opportunity to debug these packages if necessary.

Last edited 11 years ago by ericlewis (previous) (diff)

#4 @ericlewis
11 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

#5 @nacin
11 years ago

We talked about a separate directory (unsure of what we'd call it) in the root of develop.svn that can have all of our external sources. I don't know what we'd call it, but I do know that we'd want script-loader to, if running a develop.svn checkout, automatically load all of these instead of the minified ones.

#6 @kadamwhite
11 years ago

+1 to that directory, that would be of notable interest to me. Re: the Grunt question, I would assume the build process wouldn't touch these files at all—We should be trusting 3rd-party libraries like Underscore and Backbone to already be providing the optimally minified versions of their files, so we just copy those over rather than running them through our own minification process.

#7 @wonderboymusic
10 years ago

  • Keywords needs-patch added; close removed
  • Milestone changed from Awaiting Review to Future Release

#8 @wonderboymusic
9 years ago

  • Milestone changed from Future Release to 4.2

In 4.2, I would like us to answer some JS questions like this

#9 @ericlewis
9 years ago

We're not too far off from where we currently are.

WordPress-specific source JS files (i.e. un-minified versions) can be loaded by toggling the SCRIPT_DEBUG constant 1.

Some third-party scripts (e.g. Backbone.js, all jQuery UI modules) will only load the unminified version if loaded from the src directory2. Otherwise, the minified version of the script is loaded.

I propose we bring in the source and unminified versions for all third-party modules into the src/ directory, and copy both in the build process. After that, modify the script loader to respect SCRIPT_DEBUG to the tee.

Last edited 9 years ago by ericlewis (previous) (diff)

This ticket was mentioned in Slack in #core by eric. View the logs.

9 years ago

This ticket was mentioned in Slack in #core by eric. View the logs.

9 years ago

This ticket was mentioned in Slack in #core by drew. View the logs.

9 years ago

#13 @DrewAPicture
9 years ago

  • Milestone changed from 4.2 to Future Release

I'm not sure this ticket strictly belongs on a milestone since we're talking about adding external sources to a directory in the root develop.svn folder – in other words, has nothing to do with a release :-)

Moving to Future Release for triage purposes.

#14 @swissspidy
8 years ago

  • Keywords needs-patch removed
  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from reopened to closed

Let's focus on adding unminified scripts to src in #32358

Note: See TracTickets for help on using tickets.