WordPress.org

Make WordPress Core

Opened 10 months ago

Last modified 7 weeks ago

#25244 reopened enhancement

Unminified versions of MediaElement.js and MediaElementPlayer not in core

Reported by: ericlewis Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: needs-patch
Focuses: Cc:

Description

Not sure how this fits into the new Grunt build process so I'll leave this to the big boys/girls.

Change History (7)

comment:1 ericlewis10 months ago

Also mediaelementplayer.min.css

comment:2 follow-up: ocean909 months ago

  • Component changed from Media to External Libraries
  • Keywords close added

We usually doesn't include the unminified versions of external libraries in core. Why should it be included?

comment:3 in reply to: ↑ 2 ericlewis9 months ago

  • Resolution set to wontfix
  • Status changed from new to closed

Including unminified versions would allow developers to read the original JS/CSS source without leaving their development environment. I was looking for it in this case to copy, paste, and override media element's CSS. Also, If SCRIPT_DEBUG loaded them it would open up the opportunity to debug these packages if necessary.

Last edited 9 months ago by ericlewis (previous) (diff)

comment:4 ericlewis9 months ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:5 nacin9 months ago

We talked about a separate directory (unsure of what we'd call it) in the root of develop.svn that can have all of our external sources. I don't know what we'd call it, but I do know that we'd want script-loader to, if running a develop.svn checkout, automatically load all of these instead of the minified ones.

comment:6 kadamwhite8 months ago

+1 to that directory, that would be of notable interest to me. Re: the Grunt question, I would assume the build process wouldn't touch these files at all—We should be trusting 3rd-party libraries like Underscore and Backbone to already be providing the optimally minified versions of their files, so we just copy those over rather than running them through our own minification process.

comment:7 wonderboymusic7 weeks ago

  • Keywords needs-patch added; close removed
  • Milestone changed from Awaiting Review to Future Release
Note: See TracTickets for help on using tickets.