Opened 11 years ago
Closed 11 years ago
#25254 closed defect (bug) (fixed)
WP_Upgrader does not consistently call Skin methods
Reported by: | rmccue | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 3.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | has-patch needs-testing commit |
Focuses: | Cc: |
Description
In WP_Upgrader::run()
(used by the installer/upgrader routines), the header/footer/before/after methods are not called consistently.
(header
/before
/error
/after
/footer
are all references to the methods as part of the Skin object, stored in $this->skin
)
- An error in the filesystem will cause a call to
error
without first callingheader
/before
and without callingafter
/footer
. - An error in downloading or unpacking will cause calls to
header
/before
beforeerror
, but onlyafter
is called aftererror
. - An error in actually "installing" (moving into place) or a successful install will cause calls to
header
/before
(thenerror
if errored), thenafter
/footer
In order to actually make these possible to use consistently, the following order should always be followed:
header
(if not doing a multiupgrade)before
error
(or other feedback calls; the meat of the processing)after
footer
(if not doing a multiupgrade)
Attachments (2)
Change History (8)
Note: See
TracTickets for help on using
tickets.
First pass: 25254.diff (untested).