Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#25260 closed defect (bug) (fixed)

Toolbar does not always reset text-shadow

Reported by: SergeyBiryukov Owned by: helen
Milestone: 3.8 Priority: normal
Severity: minor Version:
Component: Toolbar Keywords: has-patch
Focuses: Cc:


As reported by Brent Logan on wp-testers:

The theme I'm using applies text shadow to the body selector. The admin bar showing on the blog doesn't clear this style.

I think it just became obvious when W3 Total Cache changed its "support" menu item's color to red.

The toolbar does reset text-shadow (see [17626]). I've added text-shadow: #ccc 2px -2px 0px for <body> to Twenty Thirteen's style.css, and the Toolbar style didn't change, so it doesn't actually depend on the theme.

However, I was able to reproduce the issue with the "Support" menu item from W3 Total Cache (see the screenshot). That's just inconsistent styling of the Toolbar itself (it resets text-shadow for links, but not for <span> elements inside them).

Attachments (3)

25260.png (7.1 KB) - added by SergeyBiryukov 8 years ago.
25260.patch (541 bytes) - added by SergeyBiryukov 8 years ago.
25260.2.patch (389 bytes) - added by kwight 8 years ago.

Download all attachments as: .zip

Change History (9)

8 years ago

#1 @SergeyBiryukov
8 years ago

25260.patch fixes the issue at hand. However, looking at admin-bar.css, we add text-shadow to all elements (tags/3.6/wp-includes/css/admin-bar.css#L12) and then reset it for many elements. Perhaps we should do the opposite and just add it where it's needed.

#2 @nacin
8 years ago

Sure. Helen?

#3 @helen
8 years ago

Flip it and reverse it.

That is: I agree, let's text-shadow: none in the general toolbar reset and apply it where needed instead.

8 years ago

#4 @kwight
8 years ago

[26072] removed the text-shadow property; attachment:25260.2.patch adds it back and resets to none.

#5 @helen
8 years ago

  • Milestone changed from Awaiting Review to 3.8

#6 @helen
8 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 26451:

Make sure toolbar reset includes text-shadow: none. props kwight. fixes #25260.

Note: See TracTickets for help on using tickets.