Opened 11 years ago
Closed 11 years ago
#25260 closed defect (bug) (fixed)
Toolbar does not always reset text-shadow
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.8 | Priority: | normal |
| Severity: | minor | Version: | |
| Component: | Toolbar | Keywords: | has-patch |
| Focuses: | Cc: |
Description
As reported by Brent Logan on wp-testers:
The theme I'm using applies text shadow to the body selector. The admin bar showing on the blog doesn't clear this style.
I think it just became obvious when W3 Total Cache changed its "support" menu item's color to red.
The toolbar does reset text-shadow (see [17626]). I've added text-shadow: #ccc 2px -2px 0px for <body> to Twenty Thirteen's style.css, and the Toolbar style didn't change, so it doesn't actually depend on the theme.
However, I was able to reproduce the issue with the "Support" menu item from W3 Total Cache (see the screenshot). That's just inconsistent styling of the Toolbar itself (it resets text-shadow for links, but not for <span> elements inside them).
25260.patch fixes the issue at hand. However, looking at
admin-bar.css, we addtext-shadowto all elements (tags/3.6/wp-includes/css/admin-bar.css#L12) and then reset it for many elements. Perhaps we should do the opposite and just add it where it's needed.