Use wp_get_nav_menus() instead of get_terms('nav_menu') in WP_Nav_Menu_Widget

[Frank Klein]

The wp_get_nav_menus() function has a wp_get_nav_menus filter that allows you to filter the array of menu objects returned by the function.

The WP_Nav_Menu_Widget class however uses a direct call to get_terms('nav_menu') to render the widget form. As such, the wp_get_nav_menus filter is not applied to the menus available on the widget configuration screen.

The attached patch fixes this by using the wp_get_nav_menus() function.

[SergeyBiryukov]

This should probably be wp_get_nav_menus( array( 'orderby' => 'name' ) ) to keep the current ordering (unlike get_terms(), wp_get_nav_menus() uses 'none' by default).

[Frank Klein]

Thanks, I updated the patch accordingly.

[SergeyBiryukov]

When uploading a new version of a patch, please don't overwrite the old one, so that context is preserved.

[DrewAPicture]

Tested 25263.patch​ by filtering on the wp_get_nav_menus hook before and after.

Works for me.

[wonderboymusic]

In 25332:

Use wp_get_nav_menus() instead of get_terms('nav_menu') in WP_Nav_Menu_Widget to preserve use of `wp_get_nav_menus' filter.

Props Frank Klein.
Fixes #25263.