WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#25303 closed defect (bug) (fixed)

Fix regular expression used for smiley translations to work when there is only one registered emoticon.

Reported by: yonasy's profile yonasy Owned by: wonderboymusic's profile wonderboymusic
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Formatting Keywords: has-patch needs-unit-tests
Focuses: Cc:

Description

Without this patch, the string ":) :) :) :)" will not be replaced with four smilies when ":)" is the only emoticon in $wpsmiliestrans from smilies_init(), wp-includes/functions.php.

Attachments (1)

regex.patch​ (358 bytes) - added by yonasy 11 years ago.

Download all attachments as: .zip

Change History (6)

@yonasy
11 years ago

#2 @nacin
11 years ago

  • Component changed from General to Formatting
  • Keywords has-patch needs-unit-tests added

Needs unit tests. In here: ​http://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/formatting/Smilies.php.

#3 @mdbitz
10 years ago

  • Cc matt@… added

See Unit Tests and Path in related ticket #20124

#4 @wonderboymusic
10 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 26191:

Don't place smilies inside of pre or code tags. Don't skip smilie after a smilie with an 8 in it. Fix regular expression used for smiley translations to work when there is only one registered emoticon.

Props solarissmoke, soulseekah, mdbitz, yonasy. ht to mdbitz for the Unit Tests and a comprehensive patch.
Fixes #16448, #20124, #25303.

#5 @wonderboymusic
10 years ago

  • Milestone changed from Awaiting Review to 3.8
Note: See TracTickets for help on using tickets.