WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#25340 closed defect (bug) (fixed)

the_attachment_links() function usefulness

Reported by: vinod-dalvi's profile vinod dalvi Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 3.7 Priority: normal
Severity: minor Version: 2.5
Component: Media Keywords: has-patch needs-testing
Focuses: Cc:

Description

The function the_attachment_links() was introduced in version 2.0.0 at that time it was using at admin side in inline-uploading.php file but the file is removed now and it is not used anywhere in WordPress core, the function is also not deprecated. should we maintain this function in WordPress core?

Attachments (1)

25340.patch​ (3.5 KB) - added by vinod dalvi 12 years ago.
Deprecated the function.

Download all attachments as: .zip

Change History (5)

#1 @SergeyBiryukov
12 years ago

  • Component changed from General to Media
  • Keywords needs-patch added; 2nd-opinion needs-codex removed
  • Milestone changed from Awaiting Review to 3.7
  • Version changed from 3.6.1 to 2.5

Unused since [6910]. Previously, used in wp_upload_tab_browse() via wp_upload_view(), which are both gone in [7357]. I don't see it mentioned in Codex, I guess we should just deprecate it.

@vinod dalvi
12 years ago

Deprecated the function.

#2 @vinod dalvi
12 years ago

  • Cc mozillavvd@… added
  • Keywords has-patch needs-testing added; needs-patch removed

#3 @SergeyBiryukov
12 years ago

A search in the plugin directory doesn't produce any notable references.

#4 @SergeyBiryukov
12 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 25472:

Deprecate the_attachment_links(), unused since [6910]. props vinod dalvi. fixes #25340.

Note: See TracTickets for help on using tickets.