Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#25346 closed defect (bug) (fixed)

Decode HTML characters for email subject lines

Reported by: betzster Owned by: tlovett1
Priority: normal Milestone: 3.9
Component: Mail Version:
Severity: normal Keywords: has-patch commit good-first-bug
Cc: Focuses: multisite

Description

Attachments (2)

patch-decode-subject-lines.diff​ (2.9 KB ) - added by tlovett1 13 years ago.
wp_specialchars_decode() database values in wp_mail subject lines
25346.diff​ (6.7 KB ) - added by jeremyfelt 13 years ago.

Download all attachments as: .zip

Change History (14)

#1 @nacin
13 years ago

  • Component General → Multisite
  • Keywords needs-patch added
  • Milestone Awaiting Review → Future Release

#2 @jeremyfelt
13 years ago

  • Component Multisite → Mail
  • Focuses multisite added

#3 follow-up: @jeremyfelt
13 years ago

It looks like we use wp_specialchars_decode() in a few places with email. Would it make sense to go through all wp_mail() uses and make sure that things are formatted properly? Would decoding cause any other issues?

#4 in reply to: ↑ 3 @nacin
13 years ago

Replying to jeremyfelt:

It looks like we use wp_specialchars_decode() in a few places with email. Would it make sense to go through all wp_mail() uses and make sure that things are formatted properly?

I'd say so.

#5 @jeremyfelt
13 years ago

  • Keywords good-first-bug added
  • Milestone Future Release → 3.9

@tlovett1
13 years ago

wp_specialchars_decode() database values in wp_mail subject lines

#6 @tlovett1
13 years ago

  • Keywords has-patch added; needs-patch removed

#7 @DrewAPicture
13 years ago

  • Owner set to tlovett1
  • Status new → assigned

#8 @jeremyfelt
13 years ago

25346.diff​ covers a few additional cases to those addressed in @tlovett1's initial patch. This includes a few instances where $blogname may have already been run through wp_specialchars_decode(), but then was passed to a filter before being included as the subject.

#9 @kirasong
13 years ago

  • Keywords good-first-bug removed

#10 @samuelsidler
13 years ago

  • Keywords commit added

#11 @nacin
13 years ago

  • Resolution → fixed
  • Status assigned → closed

In 27801:

Always decode special characters for email subjects.

props tlovett1, jeremyfelt.
fixes #25346.

#12 @nacin
13 years ago

  • Keywords good-first-bug added
Note: See TracTickets for help on using tickets.