WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#25346 closed defect (bug) (fixed)

Decode HTML characters for email subject lines

Reported by: betzster Owned by: tlovett1
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Mail Keywords: has-patch commit good-first-bug
Focuses: multisite Cc:
PR Number:

Attachments (2)

patch-decode-subject-lines.diff (2.9 KB) - added by tlovett1 6 years ago.
wp_specialchars_decode() database values in wp_mail subject lines
25346.diff (6.7 KB) - added by jeremyfelt 6 years ago.

Download all attachments as: .zip

Change History (14)

#1 @nacin
6 years ago

  • Component changed from General to Multisite
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

#2 @jeremyfelt
6 years ago

  • Component changed from Multisite to Mail
  • Focuses multisite added

#3 follow-up: @jeremyfelt
6 years ago

It looks like we use wp_specialchars_decode() in a few places with email. Would it make sense to go through all wp_mail() uses and make sure that things are formatted properly? Would decoding cause any other issues?

#4 in reply to: ↑ 3 @nacin
6 years ago

Replying to jeremyfelt:

It looks like we use wp_specialchars_decode() in a few places with email. Would it make sense to go through all wp_mail() uses and make sure that things are formatted properly?

I'd say so.

#5 @jeremyfelt
6 years ago

  • Keywords good-first-bug added
  • Milestone changed from Future Release to 3.9

@tlovett1
6 years ago

wp_specialchars_decode() database values in wp_mail subject lines

#6 @tlovett1
6 years ago

  • Keywords has-patch added; needs-patch removed

#7 @DrewAPicture
6 years ago

  • Owner set to tlovett1
  • Status changed from new to assigned

@jeremyfelt
6 years ago

#8 @jeremyfelt
6 years ago

25346.diff covers a few additional cases to those addressed in @tlovett1's initial patch. This includes a few instances where $blogname may have already been run through wp_specialchars_decode(), but then was passed to a filter before being included as the subject.

#9 @mikeschroder
6 years ago

  • Keywords good-first-bug removed

#10 @samuelsidler
6 years ago

  • Keywords commit added

#11 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 27801:

Always decode special characters for email subjects.

props tlovett1, jeremyfelt.
fixes #25346.

#12 @nacin
6 years ago

  • Keywords good-first-bug added
Note: See TracTickets for help on using tickets.