![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#25346 closed defect (bug) (fixed)
Decode HTML characters for email subject lines
| Reported by: | betzster | Owned by: | tlovett1 |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.9 |
| Component: | Version: | ||
| Severity: | normal | Keywords: | has-patch commit good-first-bug |
| Cc: | Focuses: | multisite |
Description
Since email subject lines are plaintext, we should decode database values that we use there. All the examples I found are related to blogname.
- http://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/ms.php?rev=25472#L214
- http://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/ms.php?rev=25472#L267
- http://core.trac.wordpress.org/browser/trunk/src/wp-admin/ms-delete-site.php?rev=25472#L72
- http://core.trac.wordpress.org/browser/trunk/src/wp-admin/user-new.php?rev=25472#L88
Related: #9913
Attachments (2)
Change History (14)
#1
@
12 years ago
- Component General → Multisite
- Keywords needs-patch added
- Milestone Awaiting Review → Future Release
#4
in reply to: ↑ 3
@
12 years ago
Replying to jeremyfelt:
It looks like we use
wp_specialchars_decode()in a few places with email. Would it make sense to go through allwp_mail()uses and make sure that things are formatted properly?
I'd say so.
#8
@
12 years ago
25346.diff covers a few additional cases to those addressed in @tlovett1's initial patch. This includes a few instances where $blogname may have already been run through wp_specialchars_decode(), but then was passed to a filter before being included as the subject.
Note:
See TracTickets
for help on using tickets.
It looks like we use
wp_specialchars_decode()in a few places with email. Would it make sense to go through allwp_mail()uses and make sure that things are formatted properly? Would decoding cause any other issues?