Make WordPress Core

Opened 2 years ago

Closed 22 months ago

Last modified 22 months ago

#25348 closed enhancement (fixed)

Autocomplete for Add New Site → Admin Email

Reported by: helen Owned by:
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch
Focuses: ui, multisite Cc:


We have autocomplete for adding users to sites - we should do the same for the admin email for a new site.

Previously: #19810

Attachments (3)

25348.diff (3.4 KB) - added by helen 23 months ago.
25348.2.diff (3.6 KB) - added by helen 23 months ago.
25348.3.diff (4.0 KB) - added by helen 22 months ago.

Download all attachments as: .zip

Change History (13)

#1 @jeremyfelt
23 months ago

  • Milestone changed from Awaiting Review to Future Release

This makes sense. I always end up relying on browser input history and that's no fun.

We would need to figure out what that list should look like and then how to retrieve that data in advance. Emails of users that are registered on the current network?

#2 @helen
23 months ago

I imagine we could make it use the same Ajax search that adding users to a site uses, just need to be able to have user_email as the value instead of user_login.

23 months ago

23 months ago

#3 @helen
23 months ago

  • Keywords has-patch added

Gave it a run in 25348.2.diff. Had to switch to an explicit .each() in the JS (as opposed to relying on jQuery's implicit one) to have access to the element.

#4 @helen
23 months ago

  • Milestone changed from Future Release to 3.9

#5 @jeremyfelt
23 months ago

25348.2.diff looks good and tests good. +1

As expected, it restricts the user search to members of the current "site". When in the network admin, the current site is the current network, so the search returns properly. If I was to create a new network, users from other networks would not return in the search.

It may be interesting to have a filter in there one day to allow for the members of multiple networks to be searched at once. I don't think that's today though. :)

It could also be nice to have an index on user_email in the DB, but it looks like we've been down that road in a couple tickets and the answer is an alter table when needed.

#6 @jeremyfelt
23 months ago

  • Component changed from Multisite to Networks and Sites
  • Focuses multisite added

22 months ago

#7 @helen
22 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In 27046:

Autocomplete for the new site admin email. Better than trying to remember which email address you used.

fixes #25348.

#8 @helen
22 months ago

#15942 was marked as a duplicate.

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.

22 months ago

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.

22 months ago

Note: See TracTickets for help on using tickets.