posts_nav_link inserts $sep too often

[Reuben]

<?php posts_nav_link('&nbsp;&nbsp;&nbsp;','Previous Resu

lts','More Results') ?></div>

The proper behaviour should be to *only* insert sep if there are both previous and next results. Otherwise, sep should not be echoed.

[ryan]

Paging by posts or by days. I think our paging by days query is not smart enough to determine if there are any days left so the next link is always shown.

[davidhouse]

Patch attached, which:

• Fixes the bug for both paging by dates and posts.
• Refactors post_nav_link() and friends to use less globals.
• Makes paging by dates smart enough to know what the maximum number of days is.

[ryan]

Maybe we should call it _max_num_pages() to denote it is a private helper function.

[davidhouse]

If you want. I thought there was a possibility of it being used elsewhere, but actually that's not very likely.

[davidhouse]

Firefox 1.0.7, Ubuntu Linux.

Nope. Still not working after Ctrl+F5'ing and manually clearing the cache through Edit -> Preferences. Same effect as above.

[davidhouse]

Nuts. that was posted on the wrong bug.

[ryan]

(In [3646]) Post paging rework from David House. fixes #2536