WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#25363 closed enhancement (fixed)

Twenty Fourteen: change diagonal lines placeholder background-attachment

Reported by: buffler Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Something that can be a bit jarring about small diagonal line patterns (like those used as a background for featured images in Twenty Fourteen) is the way they'll appear to flash as you scroll down the page.

On any site that makes good use of featured images, which the diagonal lines encourage, this won't be noticed often. But on any site that fails to make good use of featured images, the flashing-while-scrolling thing may prove distracting to its visitors.

Maybe this is really trivial? - but the fix is easy. Just adding background-attachment: fixed; to the elements that use these backgrounds will achieve the same effect but with improved results: you still have featured images (or lack thereof) with the diagonal background appearing to scroll up the page, just no flashing.

I've attached a patch (hope I do this right, it's my first).

Attachments (1)

pattern-background-attachment.patch (685 bytes) - added by buffler 7 years ago.

Download all attachments as: .zip

Change History (5)

#1 @buffler
7 years ago

  • Component changed from General to Bundled Theme
  • Version set to trunk

#2 @sabreuse
7 years ago

  • Milestone changed from Awaiting Review to 3.8

related: #25300

#3 @celloexpressions
7 years ago

This makes a big difference, should definitely go in regardless of the decision in #25300, I think (although the patches will conflict so should maybe be merged).

#4 @lancewillett
7 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25610:

Twenty Fourteen: redo the featured image background pattern with CSS plus minor style adjustments. Props iamtakashi, fixes #25300. This also fixes #25363, props buffler.

Note: See TracTickets for help on using tickets.