WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#25366 closed defect (bug) (fixed)

Twenty Fourteen: Remove rem units from the style sheet

Reported by: iamtakashi Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Having rem units makes the style sheet really large because we need to have pixel fallbacks for all. Although Twenty Twelve uses it, Twenty Thirteen doesn't. I don't think we need to use the unit for Twenty Fourteen and removing it makes the style sheet much less confusing and smaller which is good for many ways.

We discussed in Twenty Fourteen office hours on 19th September. IRC Log.

Attachments (2)

25366.diff (30.0 KB) - added by iamtakashi 6 years ago.
Remove rem units from the style sheet
25366.1.diff (38.4 KB) - added by iamtakashi 6 years ago.
Updated patch that removes rem units also from rtl.css

Download all attachments as: .zip

Change History (5)

@iamtakashi
6 years ago

Remove rem units from the style sheet

#1 @iamtakashi
6 years ago

  • Keywords has-patch added

@iamtakashi
6 years ago

Updated patch that removes rem units also from rtl.css

#2 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25523:

Twenty Fourteen: remove rem units, props iamtakashi. Fixes #25366.

#3 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.8
Note: See TracTickets for help on using tickets.