Improve the admin-bar feature comment

[nofearinc]

Can we improve the comment for hiding the admin bar in class-wp-admin-bar.php?

Suggested update applied.

[DrewAPicture]

I believe this is actually legacy code from 3.1. As far as I know this method can't be used to disable the Toolbar any more. If that's actually the case, we should just remove the comment altogether.

[nofearinc]

That might be true actually. Either way, we could take care of the comment (or the snippet) if it's no longer in use or still needed in some way.

[ocean90]

That's not a callback for hiding the toolbar. The callback controls the padding, see _admin_bar_bump_cb() which is the default callback.
So yes, we can improve it, but with the correct description. :)

[nofearinc]

Thanks, good call. Something like that maybe?

[ocean90]

Replying to nofearinc:

Thanks, good call. Something like that maybe?

I would say s/apply/remove/.

[nofearinc]

Just noticed that "default" could be "browser default" or "WordPress default" so I added extra context here. Feedback?

[ocean90]

25373.3.patch​ looks good.

@DrewAPicture Can you take a look here?

[DrewAPicture]

25373.3.patch​: Looks good, just a couple of tweaks:

• We should probably say "for the Toolbar" here for consistent messaging
• ​Multi-line comments should be in block style

[nofearinc]

rename to "the Toolbar" + multiline comment

[DrewAPicture]

25373.4.patch​ looks good.

[DrewAPicture]

In 25563:

Improve inline comment for removing default padding styles for the Toolbar.

Props nofearinc.
Fixes #25373.