![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 13 years ago
Closed 13 years ago
#25373 closed enhancement (fixed)
Improve the admin-bar feature comment
| Reported by: | nofearinc | Owned by: | DrewAPicture |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.7 |
| Component: | Inline Docs | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
Can we improve the comment for hiding the admin bar in class-wp-admin-bar.php?
Suggested update applied.
Attachments (4)
Change History (14)
#2
@
13 years ago
That might be true actually. Either way, we could take care of the comment (or the snippet) if it's no longer in use or still needed in some way.
#3
@
13 years ago
- Keywords needs-patch added; has-patch 2nd-opinion removed
That's not a callback for hiding the toolbar. The callback controls the padding, see _admin_bar_bump_cb() which is the default callback.
So yes, we can improve it, but with the correct description. :)
#6
@
13 years ago
Just noticed that "default" could be "browser default" or "WordPress default" so I added extra context here. Feedback?
#7
@
13 years ago
- Cc added
- Milestone Awaiting Review → 3.7
25373.3.patch looks good.
@DrewAPicture Can you take a look here?
#8
@
13 years ago
25373.3.patch: Looks good, just a couple of tweaks:
- We should probably say "for the Toolbar" here for consistent messaging
- Multi-line comments should be in block style
Note:
See TracTickets
for help on using tickets.
I believe this is actually legacy code from 3.1. As far as I know this method can't be used to disable the Toolbar any more. If that's actually the case, we should just remove the comment altogether.