Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#25378 closed defect (bug) (fixed)

Initialise $wp_filter and $merged_filters

Reported by: rmccue's profile rmccue Owned by: nacin's profile nacin
Milestone: 3.7 Priority: normal
Severity: trivial Version:
Component: Plugins Keywords: has-patch commit
Focuses: Cc:

Description

At the moment, $wp_filter and $merged_filters are never actually initialised, they just kind of... pop into existence. $wp_actions is checked, but that's done on every call of do_action, where we could just do them all globally.

Attached patch does just that.

Attachments (2)

25378.diff (1.8 KB) - added by rmccue 11 years ago.
We're up all night to get initialised
25378.2.diff (1.4 KB) - added by rmccue 11 years ago.
Move to plugin.php

Download all attachments as: .zip

Change History (6)

@rmccue
11 years ago

We're up all night to get initialised

@rmccue
11 years ago

Move to plugin.php

#1 follow-up: @rmccue
11 years ago

Moved to plugin.php as per dd32's comments.

#2 @SergeyBiryukov
11 years ago

  • Component changed from General to Plugins
  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.7

#3 in reply to: ↑ 1 @dd32
11 years ago

Replying to rmccue:

Moved to plugin.php as per dd32's comments.

FWIW, my comments in IRC were:

  • The file stands-alone and is used in things like BackPress
  • We fire actions/filters between the time plugin.php, and default-filters.php are included
  • We sometimes only include plugin.php, ie. error conditions
Last edited 11 years ago by dd32 (previous) (diff)

#4 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25607:

Initialize the filter globals.

props rmccue.
fixes #25378.

Note: See TracTickets for help on using tickets.