XML-RPC and wp-mail.php struggle with timezone offsets

[nacin]

See iso8601_to_datetime() and wp-mail.php, and #20328 for background.

[dossy]

See also: #30429, #35053

[Rarst]

Could we get a bit more detail on "struggles" ? :) Background issue had been marked as resolved since.

I am not too hopeful, but I will be looking into eliminating offset math as much as possible. :\

If we manage to introduce combined timezone retrieval in #24730, then a lot of old crappy logic can be upgraded to DateTime.

[nacin]

Replying to Rarst:

Could we get a bit more detail on "struggles" ? :) Background issue had been marked as resolved since.

It looks like I marked the original issue as resolved and then opened this one to deal with unresolved issues.

For wp-mail.php, this surely must have been referring to the insanity that was later changed in [34864]. Obviously it was more obvious at the time. :-)

For XML-RPC, I did note iso8601_to_datetime(), which is still used in XML-RPC and still uses timezone offset math.

[Rarst]

Hm hm, I just don't feel like this specific issue is actionable enough. Whole core suffers from offset math and that is something we are working on eliminating as a global issue.

It doesn't seem like XMLRPC & mail are any more broken than the rest of it (as of right now)?

[Rarst]

Ok, it seems like iso8601_to_datetime() is so so very broken. Added unit tests and rewrote implementation in #31809

[Rarst]

All of the conversion stuff should be fixed up in #31809, if anything still broken can be new specific ticket.