WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25404 closed defect (bug) (fixed)

Twenty Fourteen: Gap beneath header image

Reported by: taupecat Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

When user adds a header image (see #25400), a gap appears between the image and the masthead. Changing the header image's display type to "block" fixes.

Attachments (3)

Screen Shot 2013-09-23 at 10.13.16 PM.png (714.0 KB) - added by taupecat 6 years ago.
Screenshot of gap appearing between header image and masthead
25404.diff (386 bytes) - added by taupecat 6 years ago.
Patch of style.css to fix the gap by applying "display: block;" to the header image
25404.2.diff (683 bytes) - added by taupecat 6 years ago.
This patch instead of 25404.diff; puts "display: block" on all linked images and removes deprecated rules

Download all attachments as: .zip

Change History (10)

@taupecat
6 years ago

Screenshot of gap appearing between header image and masthead

@taupecat
6 years ago

Patch of style.css to fix the gap by applying "display: block;" to the header image

#1 @ramiabraham
6 years ago

Same on my nightly, good catch.

#2 follow-up: @obenland
6 years ago

  • Cc iamtakashi added
  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 3.8

I think we should use the a img selector in line 84 for that since this is a problem with all linked images. It would also make the selector in line 1509 unnecessary.

iamtakashi, can you confirm this?

#3 @taupecat
6 years ago

Changing the a img {} selector makes sense. I'll change my patch accordingly.

However, I'm not seeing how the selector at 1509 is affected...

.hentry .mejs-controls .mejs-time-rail .mejs-time-total,
.hentry .mejs-controls .mejs-horizontal-volume-slider .mejs-horizontal-volume-total {
	background: #595959;
}

#4 in reply to: ↑ 2 ; follow-up: @iamtakashi
6 years ago

Replying to obenland:

I think we should use the a img selector in line 84 for that since this is a problem with all linked images. It would also make the selector in line 1509 unnecessary.

iamtakashi, can you confirm this?

I think you're correct. This will be an issue for all linked image so it makes sense to use the selector, a img. And we should be able to get rid of vertical-align: middle; from line 1383 - 1389 (I think this is what you meant).

#5 in reply to: ↑ 4 @obenland
6 years ago

Replying to iamtakashi:

I think you're correct. This will be an issue for all linked image so it makes sense to use the selector, a img. And we should be able to get rid of vertical-align: middle; from line 1383 - 1389 (I think this is what you meant).

Cool. Right, line 1383. I hadn't svn up'ed in a while ;)

@taupecat
6 years ago

This patch instead of 25404.diff; puts "display: block" on all linked images and removes deprecated rules

#6 @obenland
6 years ago

  • Keywords needs-refresh removed

#7 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25611:

Twenty Fourteen: fix gap beneath header image, props taupecat. Fixes #25404.

Note: See TracTickets for help on using tickets.