WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #25408, comment 83


Ignore:
Timestamp:
07/07/2015 03:10:42 PM (6 years ago)
Author:
stephdau
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25408, comment 83

    initial v1  
    11I think [attachment:25408.22.diff] is great as is:
    22 * I think having it in the default (parent's) `get_default_primary_column_name()` is definitely the proper place to.
    3  * Going with a `foreach`, `continue`, and `break` is a smart move there.
     3 * Going with a `foreach`, `continue`, and `break` pattern is a smart move there.
    44
    55I fail to see a case where that would fail, at the very least as ungracefully as it does without the change.