In Admin navigation menu manager Page > View All section, home link has no label

[ericlewis]

nuff said. see attachment.

[helen]

Broken in [25285] for #14975 - it's a fake item when there's no page on front set, so get_the_title() is returning nothing.

[ericlewis]

attachment:25410.1.diff​ brings us back to 3.6 functionality with an if else check that will set the item label correctly.

#wp1337up

[ericlewis]

sorry third beer

[SergeyBiryukov]

25410.3.diff​ applies the_title filter directly instead (like we do in several other places) and simplifies the logic, removing unused string.

[DrewAPicture]

//duplicate_hook

[nacin]

25410.3.diff​ looks good.

[DrewAPicture]

25410.3.diff​ works for me. We'll snag the //duplicate_hook in #25474

[helen]

I don't think it's a good idea to remove the "Home: " prefix before the name of the page, especially if a static page is set to front. Otherwise you get this confusing thing:

It may make sense to have it be "Home: Latest posts" instead for a non-static front page. Previously it said "Home: Home". On one hand, maybe it's not actually the latest posts, but on the other, you might already have a page named "Home". Or we can leave it as "Home: Home".

[SergeyBiryukov]

Replying to helen:

Previously it said "Home: Home". On one hand, maybe it's not actually the latest posts, but on the other, you might already have a page named "Home". Or we can leave it as "Home: Home".

"Home: Home" looks weird, especially when there's no an actual page with that title. 25410.5.diff​ only adds the prefix if the title is not a translated version of "Home". Both strings already exist, no string changes here.

[paolal]

Tested 25410.diff​ and it works for me.

[SergeyBiryukov]

Replying to paolal:

Tested 25410.diff​ and it works for me.

Could you please test the latest patch, 25410.5.diff​? Or is that the one you tested?

[helen]

In 25741:

Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410.