WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#25410 closed defect (bug) (fixed)

In Admin navigation menu manager Page > View All section, home link has no label

Reported by: ericlewis Owned by: helen
Milestone: 3.7 Priority: normal
Severity: blocker Version: 3.7
Component: Menus Keywords: has-patch commit
Focuses: Cc:

Description

nuff said. see attachment.

Attachments (8)

Screen Shot 2013-09-24 at 7.53.59 PM.png (92.6 KB) - added by ericlewis 8 years ago.
25410.diff (1.7 KB) - added by ericlewis 8 years ago.
25410.1.diff (1.7 KB) - added by ericlewis 8 years ago.
25410.2.diff (921 bytes) - added by ericlewis 8 years ago.
sorry third beer
25410.3.diff (1.5 KB) - added by SergeyBiryukov 8 years ago.
25410.4.diff (1.5 KB) - added by DrewAPicture 8 years ago.
//duplicate_hook
Screen Shot 2013-10-03 at 1.12.36 PM.png (19.9 KB) - added by helen 8 years ago.
25410.5.diff (1.7 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (23)

#1 @helen
8 years ago

  • Milestone changed from Awaiting Review to 3.7

Broken in [25285] for #14975 - it's a fake item when there's no page on front set, so get_the_title() is returning nothing.

@ericlewis
8 years ago

#2 @nacin
8 years ago

  • Severity changed from normal to blocker

@ericlewis
8 years ago

#3 @ericlewis
8 years ago

attachment:25410.1.diff brings us back to 3.6 functionality with an if else check that will set the item label correctly.

#wp1337up

#4 @SergeyBiryukov
8 years ago

  • Version set to trunk

@ericlewis
8 years ago

sorry third beer

#5 @SergeyBiryukov
8 years ago

  • Keywords has-patch added; needs-patch removed

25410.3.diff applies the_title filter directly instead (like we do in several other places) and simplifies the logic, removing unused string.

@DrewAPicture
8 years ago

//duplicate_hook

#7 @nacin
8 years ago

  • Keywords commit added

#8 @DrewAPicture
8 years ago

25410.3.diff works for me. We'll snag the //duplicate_hook in #25474

#9 follow-up: @helen
8 years ago

I don't think it's a good idea to remove the "Home: " prefix before the name of the page, especially if a static page is set to front. Otherwise you get this confusing thing:

http://core.trac.wordpress.org/raw-attachment/ticket/25410/Screen%20Shot%202013-10-03%20at%201.12.36%20PM.png

It may make sense to have it be "Home: Latest posts" instead for a non-static front page. Previously it said "Home: Home". On one hand, maybe it's not actually the latest posts, but on the other, you might already have a page named "Home". Or we can leave it as "Home: Home".

#10 @helen
8 years ago

  • Keywords needs-patch added; has-patch commit removed

#11 in reply to: ↑ 9 @SergeyBiryukov
8 years ago

  • Keywords has-patch commit added; needs-patch removed

Replying to helen:

Previously it said "Home: Home". On one hand, maybe it's not actually the latest posts, but on the other, you might already have a page named "Home". Or we can leave it as "Home: Home".

"Home: Home" looks weird, especially when there's no an actual page with that title. 25410.5.diff only adds the prefix if the title is not a translated version of "Home". Both strings already exist, no string changes here.

#12 follow-up: @paolal
8 years ago

Tested 25410.diff and it works for me.

#13 in reply to: ↑ 12 @SergeyBiryukov
8 years ago

Replying to paolal:

Tested 25410.diff and it works for me.

Could you please test the latest patch, 25410.5.diff? Or is that the one you tested?

#14 @helen
8 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 25741:

Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410.

#15 @SergeyBiryukov
8 years ago

  • Version changed from trunk to 3.7
Note: See TracTickets for help on using tickets.