Changes between Initial Version and Version 1 of Ticket #25419, comment 13
- Timestamp:
- 08/14/2014 05:56:24 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #25419, comment 13
initial v1 1 1 ocean90, thanks for the feedback. 2 2 3 I guess I wasn't sure about the minified files being re-compiled, but thanks for the clarification. In regards to backwards compatibility, what I have appears to work in regards to previous version of WordPress.3 I guess I wasn't sure about the minified files being re-compiled, but thanks for the clarification. 4 4 5 Pre-patch, the constructor passes in the $option->name (string) in that argument location. With the new patch, I'm passing in an array and checking if the returned argument is indeed an array. Is this not a viable way to go about doing things? I tested against previous versions of WordPress and things appeared to be backwards compatible with the new patch.5 In regards to backwards compatibility, Pre-patch, the constructor passes in the $option->name (string) in that argument location. With the new patch, I'm passing in an array and checking if the returned argument is indeed an array. Is this not a viable way to go about doing things? I tested against previous versions of WordPress and things appeared to be backwards compatible with the new patch. 6 6 7 7 `$this->icon_url = is_array($icon_url) || empty($icon_url) ? '' : $icon_url; // create the icon url parameter `