WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#25453 closed defect (bug) (fixed)

Hooks Docs: wp-admin/options-discussion.php

Reported by: siobhyb Owned by: DrewAPicture
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch
Focuses: Cc:

Description

Patch forthcoming.

Attachments (3)

options-discussion.patch (1.5 KB) - added by siobhyb 7 years ago.
First pass at inline docs for wp-admin/options-discussion.php.
25453.diff (4.5 KB) - added by ericlewis 7 years ago.
25453.2.diff (1.9 KB) - added by DrewAPicture 7 years ago.

Download all attachments as: .zip

Change History (11)

#1 @DrewAPicture
7 years ago

  • Keywords needs-patch added

#2 @kpdesign
7 years ago

  • Cc siobhyb added
  • Type changed from enhancement to defect (bug)

Are you still working on this file?

#3 follow-up: @siobhyb
7 years ago

Hey. So sorry, some RL things got in the way which caused me to fall behind on this. Will have patches for both my open tickets by the end of the day.

#4 in reply to: ↑ 3 @kpdesign
7 years ago

Replying to siobhyb:

That's okay, just wanted to be sure you still wanted to do them. :)

@siobhyb
7 years ago

First pass at inline docs for wp-admin/options-discussion.php.

#5 @siobhyb
7 years ago

Filters:

  • thread_comments_depth_max
  • avatar_defaults
  • default_avatar_select

default_avatar_select: I think this may require some improvement, as I wasn't completely sure as to how it worked. Please let me know if I got anything wrong.

@ericlewis
7 years ago

#6 @ericlewis
7 years ago

attachment:25453.diff

  • cleans up language for the 'default_avatar_select' filter
  • makes the patch from trunk root

@DrewAPicture
7 years ago

#7 @DrewAPicture
7 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 25829:

Inline documentation for hooks in wp-admin/options-discussion.php.

Props siobhyb, ericlewis.
Fixes #25453.

#8 @DrewAPicture
7 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.7
Note: See TracTickets for help on using tickets.