WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #25459, comment 49


Ignore:
Timestamp:
12/10/2013 04:53:23 PM (7 years ago)
Author:
neil_pie
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25459, comment 49

    v1 v2  
    77If we don't need to provide developers access to edit, remove or add to the class of this element then it's completely unnecessary. If we do need to provide access to this class then filtering on it is absolutely the correct way to go in my opinion. Passing in a parameter to the function call does not provide enough flexibility, particularly if we are hoping developers will use this function beyond WP-admin.
    88
    9 One thought now occurs to me - this classname a temporary fix ( albeit for the foreseeable future ) to the fact that screen readers do not adequately support ARIA label attributes. Should we be able to switch the HTML output in the future then this classname, and passing it to the function or filtering on it all will become redundant.
     9One thought now occurs to me - this classname a temporary fix ( albeit for the foreseeable future ) to the fact that screen readers do not adequately support ARIA label attributes. Should we be able to switch the HTML output in the future then this classname, and passing it to the function or filtering on it at all will become redundant.
     10
     11I'd suggest we should agree that the solution be to hard code the 'screen-reader-text' class into the output of the function.