Make WordPress Core

Opened 2 years ago

Closed 19 months ago

Last modified 19 months ago

#25460 closed defect (bug) (fixed)

Unhelpful tab order when updating post status and visibility

Reported by: grahamarmfield Owned by: azaozz
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.6.1
Component: Editor Keywords: has-patch commit 3.9-early
Focuses: accessibility Cc:


Steps to create:

  1. Go to Edit Post screen in admin
  2. Tab to Edit (Status) link and press enter to action link. Focus is transferred to Published dropdown.
  3. Shift-tab to reverse out, and focus is transferred to bottom of page - a long way from wher you'd expect it to be.

Suggest focus is put back to the Preview Changes button in this instance.

Same is true of Edit (Visibility) link.

Attachments (1)

25460.1.diff (1.8 KB) - added by atimmer 2 years ago.

Download all attachments as: .zip

Change History (11)

@atimmer2 years ago

comment:1 @atimmer2 years ago

  • Keywords has-patch needs-unit-tests needs-testing added

25460.1.diff adds a focus() call to put focus on the html element that is sensible.

After cancel you want it to be focused on the Edit link and after you click Edit you want it to be focused on the first select or input.

Is it possible we get js unit tests for this? Can I make them somehow?

comment:2 @grahamarmfield21 months ago

Tested successfully. If the user happens to shift+tab from the status select, focus moves to the Preview Changes button - which is consistent with the tab order expected. Also, the same is true with the visibility radio buttons.

Last edited 21 months ago by grahamarmfield (previous) (diff)

comment:3 @grahamarmfield21 months ago

  • Keywords needs-testing removed

comment:4 @grahamarmfield21 months ago

Can this be committed?

comment:5 @nacin21 months ago

  • Keywords commit 3.9-early added
  • Milestone changed from Awaiting Review to Future Release

comment:6 @markoheijnen21 months ago

Just to be curious. What does need unit tests for this mean? To be able to test this we need behavior testing what we currently not do.

comment:7 @atimmer21 months ago

  • Keywords needs-unit-tests removed

You are completely correct.

comment:8 @nacin20 months ago

  • Component changed from Accessibility to Editor
  • Focuses accessibility added

comment:9 @azaozz19 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 27035:

Fix tabbing order when opening/closing post status and visibility in the Publish postbox and cache some of the jQuery selectors. Part-props atimmer, fixes #25460.

comment:10 @azaozz19 months ago

  • Milestone changed from Future Release to 3.9
Note: See TracTickets for help on using tickets.