WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#25467 closed enhancement (fixed)

Hook Docs: wp-includes/update.php

Reported by: ShinichiN Owned by: kpdesign
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch commit
Focuses: Cc:

Description

Adding inline documentation for all hooks in wp-includes/update.php

Attachments (5)

25467.diff (1.6 KB) - added by ShinichiN 8 years ago.
A inline doc patch for wp-includes/update.php
25467-2.diff (1.6 KB) - added by ShinichiN 8 years ago.
25467-3.diff (2.6 KB) - added by ShinichiN 8 years ago.
Bug fix.
25467-4.diff (2.6 KB) - added by ShinichiN 8 years ago.
Converted tab to space to make it more readable.
25467-5.diff (2.6 KB) - added by ShinichiN 8 years ago.
I got rid of the noise tabs and spaces.

Download all attachments as: .zip

Change History (11)

@ShinichiN
8 years ago

A inline doc patch for wp-includes/update.php

@ShinichiN
8 years ago

@ShinichiN
8 years ago

Bug fix.

@ShinichiN
8 years ago

Converted tab to space to make it more readable.

#1 @DrewAPicture
8 years ago

  • Owner set to kpdesign
  • Status changed from new to reviewing

#2 @kpdesign
8 years ago

@ShinichiN: Thanks for the patch. :)

I noticed a couple small things that should be fixed.

  • The @param array for $updates_counts_title: The short description and both @type lines are using tabs for indentation. They should be indented using spaces instead.
  • The line after the short description in the same docblock has an extra space and a tab after the *. The closing */ also has an extra tab after it.

It would be helpful to set your text editor to make whitespace characters visible.

Could you fix these things and resubmit the patch? :)

#3 @ShinichiN
8 years ago

Thank you for the review. I fix it now.

@ShinichiN
8 years ago

I got rid of the noise tabs and spaces.

#4 @kpdesign
8 years ago

  • Keywords commit added
  • Status changed from reviewing to accepted

@ShinichiN: Thanks for fixing those - patch looks good. :)

Recommend commit.

#5 @DrewAPicture
8 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 25699:

Inline documentation for hooks in wp-includes/update.php.

Props ShinichiN.
Fixes #25467.

#6 @DrewAPicture
8 years ago

  • Milestone changed from Awaiting Review to 3.7
Note: See TracTickets for help on using tickets.