WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#25469 closed defect (bug) (fixed)

Hook Docs: wp-settings.php

Reported by: miyauchi Owned by: DrewAPicture
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: needs-patch
Focuses: Cc:

Description

Attached patch has done for the all hooks in wp-settings.php

Attachments (3)

wp-settings.diff (1.8 KB) - added by miyauchi 8 years ago.
patch for wp-settings.php
wp-settings.2.diff (1.8 KB) - added by miyauchi 8 years ago.
some fix
25469.diff (1.9 KB) - added by DrewAPicture 8 years ago.
Final.

Download all attachments as: .zip

Change History (8)

@miyauchi
8 years ago

patch for wp-settings.php

#1 @DrewAPicture
8 years ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing

#2 follow-up: @DrewAPicture
8 years ago

  • Keywords needs-patch added; has-patch removed
  • Type changed from enhancement to defect (bug)

Hi, thanks for the patch. Some notes on wp-settings.diff:

plugins_loaded hook:

  • "Fires once plugins are loaded."

sanitize_comment_cookies hook:

  • Pretty vague. Maybe "Fires when comment cookies are sanitized."

setup_theme hook:

  • Should be a complete sentence. Maybe "Fires before the theme is loaded."

after_setup_theme hook:

  • "Fires after the theme is loaded."

init hook:

  • "Runs" should be "Fires"

@miyauchi
8 years ago

some fix

#3 in reply to: ↑ 2 @miyauchi
8 years ago

Hi, I was fixed! Thanks. :)

@DrewAPicture
8 years ago

Final.

#4 @DrewAPicture
8 years ago

  • Milestone changed from Awaiting Review to 3.7

#5 @DrewAPicture
8 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 25721:

Inline documentation for hooks in wp-settings.php.

Props miyauchi.
Fixes #25469

Note: See TracTickets for help on using tickets.