Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#25470 closed defect (bug) (fixed)

Leftover code in Plugin_Upgrader and Plugin_Upgrader_Skin classes

Reported by: jdgrimes's profile jdgrimes Owned by: dd32's profile dd32
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:


There is some code in the Plugin_Upgrader and Plugin_Upgrader_Skin classes that is no longer used, and wasn't cleaned out when Bulk_Plugin_Upgrader_Skin was introduced in [13602].

Plugin_Upgrader::$show_before is no longer used, and so Plugin_Upgrader_Skin::before() doesn't actually do anything.

Attachments (1)

25470.diff (986 bytes) - added by jdgrimes 11 years ago.
Removes the unused code

Download all attachments as: .zip

Change History (3)

11 years ago

Removes the unused code

#1 @dd32
11 years ago

  • Milestone changed from Awaiting Review to 3.8

This could potentially be a issue for any plugins who are re-using the Plugin_Upgrader_Skin class with their own WP_Upgrader instance.

Most users would probably need their own skin, or can't really use this parameter without overwriting ::after() either, so that might not be an actual issue.

#2 @dd32
11 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 26015:

Remove dead code from the Plugin Upgrader class. Props jdgrimes. Fixes #25470

Note: See TracTickets for help on using tickets.