WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

Last modified 5 months ago

#25473 closed defect (bug) (worksforme)

wp_text_diff creates wrong number of columns if title arguments are set

Reported by: joedolson Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.6.1
Component: Revisions Keywords: has-patch 2nd-opinion close
Focuses: Cc:

Description

The 3rd parameter for wp_text_diff is an array with 3 possible arguments. If any of those arguments are provided, the thead element will contain 4 columns, but the text diff renderer has only produced 3 columns of data since version 3.6.

Patch revises wp_text_diff to generate only 3 columns.

Attachments (1)

25473.wp-text-diff.patch (758 bytes) - added by joedolson 7 months ago.
Patch to wp_text_diff

Download all attachments as: .zip

Change History (5)

joedolson7 months ago

Patch to wp_text_diff

comment:1 c4xpl0siv37 months ago

  • Resolution set to worksforme
  • Status changed from new to closed

Tested and fine

comment:2 c4xpl0siv37 months ago

  • Keywords 2nd-opinion close added

comment:3 joedolson7 months ago

Can I ask how you tested this? Based on my check and code review, this is very clearlya bug, though it's not expressed in the built-in usage of revisions. I'm open to the possibility I'm missing something, but would appreciate knowing what I'm missing.

comment:4 markoheijnen5 months ago

  • Milestone Awaiting Review deleted

Clearing out the milestones for closed tickets on Awaiting Review

Note: See TracTickets for help on using tickets.