WordPress.org

Make WordPress Core

Opened 7 months ago

Last modified 3 weeks ago

#25478 new defect (bug)

Add style class hook to wp-activate.php screen so default themes can style them better

Reported by: ocean90 Owned by:
Milestone: Future Release Priority: low
Severity: minor Version:
Component: Login and Registration Keywords: has-patch
Focuses: multisite Cc:

Description

Screenshot: http://cl.ly/RkeB

Sadly, there is no container CSS class, like we have on wp-signup.php (.mu_register). Not sure if it's fixable in theme.
Otherwise we should add a wrapper on wp-activate.php, see attached patch as an example.

Attachments (4)

25478.patch (7.0 KB) - added by ocean90 7 months ago.
25478.1.diff (8.3 KB) - added by cuvelier 6 months ago.
added 2013 styles
25478.diff (958 bytes) - added by jeremyfelt 5 months ago.
25478.2.diff (1.3 KB) - added by jeremyfelt 4 weeks ago.

Download all attachments as: .zip

Change History (19)

ocean907 months ago

cuvelier6 months ago

added 2013 styles

comment:1 cuvelier6 months ago

added styles for the class ms-activate-container to match that of wp-signup.php, lookin' good.

comment:2 obenland6 months ago

  • Keywords has-patch dev-feedback added
  • Milestone changed from Awaiting Review to 3.8

Can we move forward with this?

I think adding a wrapper on wp-activate.php to make it consistent with wp-signup.php would make this a ton easier.

comment:3 lancewillett6 months ago

  • Component changed from Bundled Theme to Multisite
  • Summary changed from Twenty Thirteen: wp-activate.php looks broken to Add style class hook to wp-activate.php screen so default themes can style them better

.1 patch also includes Twenty Thirteen styles.

See also #25479 for Twenty Fourteen styles.

comment:4 lancewillett5 months ago

  • Cc lancewillett added
  • Keywords dev-feedback removed

comment:5 follow-up: ocean905 months ago

ms-activate-container and ms-signup-container were just my first idea. Not sure if they are clear enough, since there is currently no class with the prefix ms-. Should it be just with wp- like wp-signup and wp-activate? And should we also add *one* class for both types?

comment:6 in reply to: ↑ 5 lancewillett5 months ago

Replying to ocean90:

ms-activate-container and ms-signup-container were just my first idea. Not sure if they are clear enough, since there is currently no class with the prefix ms-. Should it be just with wp- like wp-signup and wp-activate? And should we also add *one* class for both types?

One class would be ideal, but then you break back compat. I think a "wp-" prefix would be better than "ms-".

jeremyfelt5 months ago

comment:7 jeremyfelt5 months ago

+1 for wp- prefixed. 25478.diff adds wp-activate-container and wp-signup-container to each respectively.

I was wondering if it would make more sense to use a body class, as the #content container is already there, it just needs additional targeting. I have no major opinion either way, but it would be nice to see some styles on these.

comment:8 matt5 months ago

  • Milestone changed from 3.8 to Future Release

Bumping from 3.8 since there hasn't been much going on here in past two weeks.

comment:9 lkraav3 months ago

+1 for body class

comment:10 jeremyfelt3 months ago

  • Milestone changed from Future Release to WordPress.org
  • Priority changed from normal to low
  • Severity changed from normal to minor

Moving to 3.9 for discussion. This seems like something we're close on.

comment:11 nacin3 months ago

  • Milestone changed from WordPress.org to 3.9

comment:12 jeremyfelt3 months ago

  • Component changed from Multisite to Login and Registration
  • Focuses multisite added

jeremyfelt4 weeks ago

comment:14 jeremyfelt4 weeks ago

Using body classes seems to make more sense here. This allows other elements on the page to be targeted based on the page load rather than relying on the container.

25478.2.diff filters body_class for both signup and activation.

comment:15 jeremyfelt3 weeks ago

  • Milestone changed from 3.9 to Future Release

We can probably push this off until we better clarify what's needed. For the time being, a body class can be added via filter on the signup_header action by a theme or plugin if necessary.

Note: See TracTickets for help on using tickets.