Opened 12 years ago
Closed 10 years ago
#25478 closed defect (bug) (fixed)
Add style class hook to wp-activate.php screen so default themes can style them better
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.4 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Login and Registration | Keywords: | has-patch |
| Focuses: | multisite | Cc: |
Description
Screenshot: http://cl.ly/RkeB
Sadly, there is no container CSS class, like we have on wp-signup.php (.mu_register). Not sure if it's fixable in theme.
Otherwise we should add a wrapper on wp-activate.php, see attached patch as an example.
Attachments (4)
Change History (22)
#1
@
12 years ago
added styles for the class ms-activate-container to match that of wp-signup.php, lookin' good.
#2
@
12 years ago
- Keywords has-patch dev-feedback added
- Milestone changed from Awaiting Review to 3.8
Can we move forward with this?
I think adding a wrapper on wp-activate.php to make it consistent with wp-signup.php would make this a ton easier.
#3
@
12 years ago
- Component changed from Bundled Theme to Multisite
- Summary changed from Twenty Thirteen: wp-activate.php looks broken to Add style class hook to wp-activate.php screen so default themes can style them better
.1 patch also includes Twenty Thirteen styles.
See also #25479 for Twenty Fourteen styles.
#5
follow-up:
↓ 6
@
12 years ago
ms-activate-container and ms-signup-container were just my first idea. Not sure if they are clear enough, since there is currently no class with the prefix ms-. Should it be just with wp- like wp-signup and wp-activate? And should we also add *one* class for both types?
#6
in reply to:
↑ 5
@
12 years ago
Replying to ocean90:
ms-activate-containerandms-signup-containerwere just my first idea. Not sure if they are clear enough, since there is currently no class with the prefixms-. Should it be just withwp-likewp-signupandwp-activate? And should we also add *one* class for both types?
One class would be ideal, but then you break back compat. I think a "wp-" prefix would be better than "ms-".
#7
@
12 years ago
+1 for wp- prefixed. 25478.diff adds wp-activate-container and wp-signup-container to each respectively.
I was wondering if it would make more sense to use a body class, as the #content container is already there, it just needs additional targeting. I have no major opinion either way, but it would be nice to see some styles on these.
#8
@
12 years ago
- Milestone changed from 3.8 to Future Release
Bumping from 3.8 since there hasn't been much going on here in past two weeks.
#10
@
12 years ago
- Milestone changed from Future Release to WordPress.org
- Priority changed from normal to low
- Severity changed from normal to minor
Moving to 3.9 for discussion. This seems like something we're close on.
#12
@
12 years ago
- Component changed from Multisite to Login and Registration
- Focuses multisite added
#14
@
12 years ago
Using body classes seems to make more sense here. This allows other elements on the page to be targeted based on the page load rather than relying on the container.
25478.2.diff filters body_class for both signup and activation.
#15
@
12 years ago
- Milestone changed from 3.9 to Future Release
We can probably push this off until we better clarify what's needed. For the time being, a body class can be added via filter on the signup_header action by a theme or plugin if necessary.
#16
@
10 years ago
- Keywords dev-feedback added
- Priority changed from low to normal
- Severity changed from minor to normal
#17
@
10 years ago
- Keywords dev-feedback removed
- Milestone changed from Future Release to 4.4
- Owner set to jeremyfelt
- Status changed from new to accepted
Let's match the container structure that exists in wp-signup.php already and use the wp-signup-container and wp-activate-container classes to differentiate.
Note that #content is now #signup-content in each after #33843.
added 2013 styles