WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 11 months ago

#25478 closed defect (bug) (fixed)

Add style class hook to wp-activate.php screen so default themes can style them better

Reported by: ocean90 Owned by: jeremyfelt
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch
Focuses: multisite Cc:

Description

Screenshot: http://cl.ly/RkeB

Sadly, there is no container CSS class, like we have on wp-signup.php (.mu_register). Not sure if it's fixable in theme.
Otherwise we should add a wrapper on wp-activate.php, see attached patch as an example.

Attachments (4)

25478.patch (7.0 KB) - added by ocean90 3 years ago.
25478.1.diff (8.3 KB) - added by cuvelier 3 years ago.
added 2013 styles
25478.diff (958 bytes) - added by jeremyfelt 3 years ago.
25478.2.diff (1.3 KB) - added by jeremyfelt 2 years ago.

Download all attachments as: .zip

Change History (22)

@ocean90
3 years ago

@cuvelier
3 years ago

added 2013 styles

#1 @cuvelier
3 years ago

added styles for the class ms-activate-container to match that of wp-signup.php, lookin' good.

#2 @obenland
3 years ago

  • Keywords has-patch dev-feedback added
  • Milestone changed from Awaiting Review to 3.8

Can we move forward with this?

I think adding a wrapper on wp-activate.php to make it consistent with wp-signup.php would make this a ton easier.

#3 @lancewillett
3 years ago

  • Component changed from Bundled Theme to Multisite
  • Summary changed from Twenty Thirteen: wp-activate.php looks broken to Add style class hook to wp-activate.php screen so default themes can style them better

.1 patch also includes Twenty Thirteen styles.

See also #25479 for Twenty Fourteen styles.

#4 @lancewillett
3 years ago

  • Cc lancewillett added
  • Keywords dev-feedback removed

#5 follow-up: @ocean90
3 years ago

ms-activate-container and ms-signup-container were just my first idea. Not sure if they are clear enough, since there is currently no class with the prefix ms-. Should it be just with wp- like wp-signup and wp-activate? And should we also add *one* class for both types?

#6 in reply to: ↑ 5 @lancewillett
3 years ago

Replying to ocean90:

ms-activate-container and ms-signup-container were just my first idea. Not sure if they are clear enough, since there is currently no class with the prefix ms-. Should it be just with wp- like wp-signup and wp-activate? And should we also add *one* class for both types?

One class would be ideal, but then you break back compat. I think a "wp-" prefix would be better than "ms-".

@jeremyfelt
3 years ago

#7 @jeremyfelt
3 years ago

+1 for wp- prefixed. 25478.diff adds wp-activate-container and wp-signup-container to each respectively.

I was wondering if it would make more sense to use a body class, as the #content container is already there, it just needs additional targeting. I have no major opinion either way, but it would be nice to see some styles on these.

#8 @matt
3 years ago

  • Milestone changed from 3.8 to Future Release

Bumping from 3.8 since there hasn't been much going on here in past two weeks.

#9 @lkraav
3 years ago

+1 for body class

#10 @jeremyfelt
3 years ago

  • Milestone changed from Future Release to WordPress.org
  • Priority changed from normal to low
  • Severity changed from normal to minor

Moving to 3.9 for discussion. This seems like something we're close on.

#11 @nacin
3 years ago

  • Milestone changed from WordPress.org to 3.9

#12 @jeremyfelt
3 years ago

  • Component changed from Multisite to Login and Registration
  • Focuses multisite added

@jeremyfelt
2 years ago

#14 @jeremyfelt
2 years ago

Using body classes seems to make more sense here. This allows other elements on the page to be targeted based on the page load rather than relying on the container.

25478.2.diff filters body_class for both signup and activation.

#15 @jeremyfelt
2 years ago

  • Milestone changed from 3.9 to Future Release

We can probably push this off until we better clarify what's needed. For the time being, a body class can be added via filter on the signup_header action by a theme or plugin if necessary.

#16 @chriscct7
11 months ago

  • Keywords dev-feedback added
  • Priority changed from low to normal
  • Severity changed from minor to normal

#17 @jeremyfelt
11 months ago

  • Keywords dev-feedback removed
  • Milestone changed from Future Release to 4.4
  • Owner set to jeremyfelt
  • Status changed from new to accepted

Let's match the container structure that exists in wp-signup.php already and use the wp-signup-container and wp-activate-container classes to differentiate.

Note that #content is now #signup-content in each after #33843.

#18 @jeremyfelt
11 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 34814:

MS: Align HTML structure in wp-signup.php and wp-activate.php.

Assigns the wp-activate-container and wp-signup-container to the container inside #signup-container on each. This container already existed in wp-signup.php and is new in wp-activate.php.

Props ocean90.
Fixes #25478.

Note: See TracTickets for help on using tickets.