WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25489 closed defect (bug) (fixed)

Unnecessary use of sprintf on gettexted string in WP_Plugin_Install_List_Table

Reported by: jdgrimes Owned by: SergeyBiryukov
Milestone: 3.9 Priority: low
Severity: trivial Version: 3.0
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

In WP_Plugin_Install_List_Table, the string "Update Now" is unnecessarily being passed through sprintf after it is gettexted.

Attachments (1)

25489.diff (860 bytes) - added by jdgrimes 6 years ago.

Download all attachments as: .zip

Change History (4)

@jdgrimes
6 years ago

#1 @yoavf
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.9
  • Priority changed from normal to low
  • Severity changed from normal to trivial

#2 @SergeyBiryukov
6 years ago

  • Version changed from 3.1 to 3.0

Used to be 'Update to version %s', changed to 'Update Now' in [13950].

#3 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26943:

Remove unnecessary sprintf(). props jdgrimes. fixes #25489.

Note: See TracTickets for help on using tickets.