Sorting posts in ascending order of date at admin side

[vinod dalvi]

Posts are displayed in descending order of date in the admin side but if we click on date column header to sort it then again it is sorted in descending order of date instead it should be sorted in ascending order of date.

[vinod dalvi]

Patch file

[SergeyBiryukov]

Related: [16593]

[swissspidy]

Patch still applies and works like a charm:

1. Posts are still sorted in descending order by default.
2. Clicking the column changes order to ascending (instead of still being in descending order).

Sounds like a no-brainer to me.

[wonderboymusic]

Probably needs to be more like 25493.diff​, which is still weird - it's not the right solution because it arbitrarily defaults to date. In the previous patch, the CSS classes weren't reflecting the proper state. There is no real holder of the state of the request, so it is hard to parse out what the values of orderby and order are when there is no query string. order gets filled in, orderby does not.

[swissspidy]

Hmm this also breaks the page list table, as you can see here: ​https://cloudup.com/cpFvtS3S_7p

It indicates that pages are ordered by date, but in fact they're ordered alphabetically.

[wonderboymusic]

In 34728:

Post List Table: Ensure that edit.php with no query string produces the proper markup and links in the date column header.

Add 2 methods to WP_List_Table, ->get_orderby() and ->get_order(). Override the methods in WP_Posts_List_Table.

WP_Posts_List_Table calls wp_edit_posts_query() in ->prepare_items() which is a wrapper for wp(). As such, we can obtain orderby and order via get_query_var(), instead of the URL.

Fixes #25493.

[SergeyBiryukov]

In 35482:

Post List Table: Hierarchical post types should not default to sorting by date.

Regression introduced in [34728].

Props ellie.roepken.
Fixes #34473. See #25493.

[cklosows]

@wonderboymusic:

The addition of the get_orderby and get_order methods in class-wp-posts-list-table.php seems to have caused the sorting of custom columns for a custom post type fail when using the filter method, instead of extending the WP_List_Table class.

In the main class-wp-list-table.php these methods pull from $_GET

	/**
	 * If 'orderby' is set, return it.
	 *
	 * @access protected
	 * @since 4.4.0
	 *
	 * @return string The value of 'orderby' or empty string.
	 */
	protected function get_orderby() {
		if ( isset( $_GET['orderby'] ) ) {
			return $_GET['orderby'];
		}

		return '';
	}

	/**
	 * If 'order' is 'desc', return it. Else return 'asc'.
	 *
	 * @access protected
	 * @since 4.4.0
	 *
	 * @return string 'desc' or 'asc'.
	 */
	protected function get_order() {
		if ( isset( $_GET['order'] ) && 'desc' === $_GET['order'] ) {
			return 'desc';
		}

		return 'asc';
	}

However in class-wp-posts-list-table.php they are relying on the get_query_var() function, which in order to do a meta query sort, requires setting the orderby to meta_value or meta_value_num.

Am I missing something in this case? Here is a link to the implementation used in the Easy Digital Downloads core:
​https://github.com/easydigitaldownloads/Easy-Digital-Downloads/blob/master/includes/admin/downloads/dashboard-columns.php#L115

[boonebgorges]

#34691 was marked as a duplicate.

[cklosows]

Uses $_GETorderby? instead of get_query_var(), like base class

[wonderboymusic]

In 35682:

List Tables: After [34728], don't try to infer orderby from query params.

List tables are really good.

Props cklosows.
Fixes #25493.

[ocean90]

See ​https://wordpress.slack.com/archives/core/p1449513505003413, ​https://wordpress.slack.com/archives/core/p1449270047003055 and #34825.

[ocean90]

Revert

[ocean90]

25493.2.patch​ reverts [34728] and [35482]. Part of [34728] was already reverted in [35682].

[ocean90]

In 35818:

List Tables: Revert [34728] and [35482].

Part of [34728] was already reverted in [35682], but the default values still made it impossible to set a default ordering for custom post types.

See #25493.
See #34825.

[ocean90]

In 35819:

List Tables: Revert [34728] and [35482].

Part of [34728] was already reverted in [35682], but the default values still made it impossible to set a default ordering for custom post types.

Merge of [35818] for the 4.4 branch.

See #25493.
Fixes #34825.