WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#25496 closed defect (bug) (fixed)

Hook Docs: wp-admin/tools.php

Reported by: lauriemrauch Owned by: DrewAPicture
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch commit
Focuses: Cc:

Description

Inline documentation for do_action ('tool_box') and also grammatical edits to text.

Attachments (4)

tools.php (4.1 KB) - added by lauriemrauch 7 years ago.
Tools Administration Screen with inline docs for hooks
25496.diff (405 bytes) - added by dougwollison 7 years ago.
Revised doc in .diff format.
25496.2.diff (2.4 KB) - added by dougwollison 7 years ago.
Shortened description, also copied over "grammatical fixes" from original patch.
25496.3.diff (347 bytes) - added by DrewAPicture 7 years ago.

Download all attachments as: .zip

Change History (10)

@lauriemrauch
7 years ago

Tools Administration Screen with inline docs for hooks

#1 @DrewAPicture
7 years ago

  • Keywords needs-patch added

Hi, can you please re-upload your patch in either .diff or .patch format?

#2 @DrewAPicture
7 years ago

  • Summary changed from hook_docs:wp-admin/tools.php to Hook Docs: wp-admin/tools.php

@dougwollison
7 years ago

Revised doc in .diff format.

#3 @DrewAPicture
7 years ago

In 25496.diff:

  • The long description can be removed.
  • "Fires actions to be run before end end of the tool-box wrapper." can be shortened to something like "Fires before the end of the tool-box wrapper."

@dougwollison
7 years ago

Shortened description, also copied over "grammatical fixes" from original patch.

#4 @kpdesign
7 years ago

@dougwollison: Thanks for updated patch.

We are only documenting hooks, so the grammatical fixes should be removed from the patch.

Could you please update the patch to only include the do_action doc block and resubmit? :)

@DrewAPicture
7 years ago

#5 @DrewAPicture
7 years ago

  • Keywords has-patch commit added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.8

#6 @DrewAPicture
7 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 25937:

Inline documentation for hooks in wp-admin/tool.php.

Props dougwollison for the initial patch.
Fixes #25496.

Note: See TracTickets for help on using tickets.