WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#25497 closed defect (bug) (fixed)

Hooks Docs: wp-admin/network/site-users.php

Reported by: sboisvert Owned by: kpdesign
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch commit
Focuses: Cc:

Description

Patch for hooks inside wp-admin/network/site-users.php

Attachments (4)

site-users.php.patch (1.2 KB) - added by sboisvert 8 years ago.
25497.2.diff (2.1 KB) - added by kpdesign 8 years ago.
Second pass
25497.3.diff (2.1 KB) - added by kpdesign 8 years ago.
Fixed doc block for show_network_site_users_add_new_form
25497.diff (2.1 KB) - added by DrewAPicture 8 years ago.
Clean up

Download all attachments as: .zip

Change History (11)

#1 @DrewAPicture
8 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to kpdesign
  • Status changed from new to reviewing

Hi, thanks for the patch. Some notes on site-users.php.patch:

  • All short descriptions need a period.

show_network_site_users_add_existing_form filter:

  • The suggested language for a boolean-style filter is to say something like, "Whether to <perform something>". It's also necessary to provide the context, in this case that would be Multisite. So maybe change "Disable showing add existing user form" to something like "Whether to show the Add Existing User form in the Site Users screen."

network_site_users_after_list_table hook:

  • Add a parameter doc for the parameter with the type: string.
Last edited 8 years ago by DrewAPicture (previous) (diff)

@kpdesign
8 years ago

Second pass

#2 @kpdesign
8 years ago

  • Keywords has-patch added; needs-patch removed

@kpdesign
8 years ago

Fixed doc block for show_network_site_users_add_new_form

#3 @kpdesign
8 years ago

  • Severity changed from trivial to normal

#4 @sboisvert
8 years ago

Thanks kpdesign and DrewAPicture.
I'm really sorry I didn't get a chance to clean this up. I'll try to get a few more in, hopefully each better than the last in the coming week.

@DrewAPicture
8 years ago

Clean up

#5 @DrewAPicture
8 years ago

  • Milestone changed from Awaiting Review to 3.8
  • Version trunk deleted

25497.diff looks good to me. @kpdesign?

#6 @kpdesign
8 years ago

  • Keywords commit added

25497.diff looks good to me. Recommend commit.

#7 @DrewAPicture
8 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 25939:

Inline documentation for hooks in wp-admin/network/site-users.php.

Props sboisvert for the initial patch. Props kpdesign.
Fixes #25497.

Note: See TracTickets for help on using tickets.