Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#25497 closed defect (bug) (fixed)

Hooks Docs: wp-admin/network/site-users.php

Reported by: sboisvert Owned by: kpdesign
Priority: normal Milestone: 3.8
Component: Inline Docs Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Patch for hooks inside wp-admin/network/site-users.php

Attachments (4)

site-users.php.patch (1.2 KB ) - added by sboisvert 13 years ago.
25497.2.diff (2.1 KB ) - added by kpdesign 13 years ago.
Second pass
25497.3.diff (2.1 KB ) - added by kpdesign 13 years ago.
Fixed doc block for show_network_site_users_add_new_form
25497.diff (2.1 KB ) - added by DrewAPicture 13 years ago.
Clean up

Download all attachments as: .zip

Change History (11)

#1 @DrewAPicture
13 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to kpdesign
  • Status newreviewing

Hi, thanks for the patch. Some notes on site-users.php.patch:

  • All short descriptions need a period.

show_network_site_users_add_existing_form filter:

  • The suggested language for a boolean-style filter is to say something like, "Whether to <perform something>". It's also necessary to provide the context, in this case that would be Multisite. So maybe change "Disable showing add existing user form" to something like "Whether to show the Add Existing User form in the Site Users screen."

network_site_users_after_list_table hook:

  • Remove the blank line after the @since line.
  • The boolean parameter with a value of true is missing from the do_action() call
  • Add a parameter doc for the missing boolean parameter
Version 0, edited 13 years ago by DrewAPicture (next)

@kpdesign
13 years ago

Second pass

#2 @kpdesign
13 years ago

  • Keywords has-patch added; needs-patch removed

@kpdesign
13 years ago

Fixed doc block for show_network_site_users_add_new_form

#3 @kpdesign
13 years ago

  • Severity trivialnormal

#4 @sboisvert
13 years ago

Thanks kpdesign and DrewAPicture.
I'm really sorry I didn't get a chance to clean this up. I'll try to get a few more in, hopefully each better than the last in the coming week.

@DrewAPicture
13 years ago

Clean up

#5 @DrewAPicture
13 years ago

  • Milestone Awaiting Review3.8
  • Version trunk

25497.diff looks good to me. @kpdesign?

#6 @kpdesign
13 years ago

  • Keywords commit added

25497.diff looks good to me. Recommend commit.

#7 @DrewAPicture
13 years ago

  • Resolutionfixed
  • Status reviewingclosed

In 25939:

Inline documentation for hooks in wp-admin/network/site-users.php.

Props sboisvert for the initial patch. Props kpdesign.
Fixes #25497.

Note: See TracTickets for help on using tickets.