Hooks Docs: wp-admin/includes/schema.php

[johnafish]

Attached patch has docs for the populate_options action in wp-admin/includes/schema.php.

[johnafish]

Inline Hook Docs For: wp-admin/includes/schema.php

[DrewAPicture]

Hi, can you please re-upload your patch in either .diff or .patch format?

[johnafish]

Sorry about that, mind just slipped away. Will update other ticket similarly.

[johnafish]

Patch from wp root

[kpdesign]

@jonafish: Thanks for the patch. :)

A few things I noticed that need fixed:

• Please use tabs to indent the doc block from the left gutter rather than spaces (when needed).
• Indent the doc block at the same level as the action or filter:

 	/**
	 * Fires before creating WordPress options and setting their default values.
	 *
	 * @since 2.6.0
	 */
	do_action( 'populate_options' );

• The @since version for populate_actions should be 2.6.0. A good reference to use is ​Adam Brown's Hook Reference for finding the version a hook was added. If you are unable to find it, just use @since Unknown and we can try to trace it.
• It's okay to space out the action or filter line to bring it inline with the coding standards. For example, do_action('populate_options'); can be changed to do_action( 'populate_options' );. That is the only whitespace fixes that should be done.

Could you make these changes and resubmit the patch? :)

[kpdesign]

Second pass

[kpdesign]

25498.2.diff​ still applies cleanly.

[DrewAPicture]

Clean up

[DrewAPicture]

25498.diff​ has a bit of clean up. Includes minor changes to the phpdoc for the parent function.

[DrewAPicture]

In 25938:

Inline documentation for hooks in wp-admin/includes/schema.php.

Props johnafish, kpdesign.
Fixes #25498.