WordPress.org
Get WordPress

Make WordPress Core

Opened 20 years ago

Closed 20 years ago

Last modified 19 years ago

#2550 closed defect (bug) (fixed)

remove smilies uksort

Reported by: random's profile random Owned by: markjaquith's profile markjaquith
Milestone: Priority: low
Severity: trivial Version: 2.0.1
Component: Optimization Keywords: smilies
Focuses: Cc:

Description

The sort of the smilies array in vars.php is slow and pointless. It's adding ~1.5% overhead to every page load on my stock install.

As far as I can tell, it just rearranges the array on the off chance that a) you happen to display the smilies in a row with (e.g.) wp-grins, and b) you actually care what order they appear in. That isn't most people, and it can be done in a ​plugin besides.

See also ​#213: even if smilies stay in the core, they don't need to be editable by adding functions to wp-config.php, especially when the result is a slower WordPress for everybody else.

Attachments (1)

vars.php.diff​ (528 bytes) - added by random 20 years ago.
removes uksort & smiliescmp()

Download all attachments as: .zip

Change History (6)

@random
20 years ago

removes uksort & smiliescmp()

#1 @markjaquith
20 years ago

  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

Agreed. I've never seen anyone print the list out, so that's something a plugin could handle.

+1

#2 @ryan
20 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3640]) Remove smilies sort. Props random. fixes #2550

#3 @ryan
20 years ago

  • Milestone changed from 2.1 to 2.0.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 2.0.3 inclusion.

#4 @ryan
20 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3741]) Remove smilies sort. Props random. fixes #2550

#5 @(none)
19 years ago

  • Milestone 2.0.3 deleted

Milestone 2.0.3 deleted

Note: See TracTickets for help on using tickets.