WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#25501 closed defect (bug) (fixed)

Hooks Docs: wp-admin/widgets.php

Reported by: r3df Owned by: kpdesign
Priority: normal Milestone: 3.7
Component: Inline Docs Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Attached patch for actions: sidebar_admin_setup, widgets_admin_page, sidebar_admin_page in wp-admin/widgets.php

Attachments (2)

widgets.php.patch​ (1.5 KB ) - added by r3df 13 years ago.
Revised Patch
25501.2.diff​ (1.3 KB ) - added by kpdesign 13 years ago.
Second pass on widgets.php.patch

Download all attachments as: .zip

Change History (8)

#1 @DrewAPicture
13 years ago

  • Keywords has-patch added
  • Owner set to kpdesign
  • Status new → reviewing

#2 @DrewAPicture
13 years ago

  • Keywords needs-patch added; has-patch removed

Hi, thanks for the patch. Looks pretty good.

Some notes on widgets.php.patch​:

  • No blank line below the @since lines if there are no parameters to document.
  • Wrap lines at the recommended ~80 characters.

widgets_admin_page hook:

  • Needs a short description.

sidebar_admin_page hook:

  • Needs a short description.

@r3df
13 years ago

Revised Patch

#3 @DrewAPicture
13 years ago

  • Keywords has-patch added; needs-patch removed

@kpdesign
13 years ago

Second pass on widgets.php.patch

#4 @DrewAPicture
13 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 3.7

25501.2.diff​ looks pretty good to me.

#5 @DrewAPicture
13 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 25734:

Inline documentation for hooks in wp-admin/widgets.php.

Props r3df, kpdesign.
Fixes #25501.

#6 @DrewAPicture
13 years ago

In 27823:

The sidebar_admin_setup hook should only be documented once in wp-admin/widgets.php. All others are duplicates.

See #25374, #25501, #27531.

Note: See TracTickets for help on using tickets.