WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#25503 closed defect (bug) (fixed)

Hooks Docs: wp-includes/category.php

Reported by: ben.moody Owned by: DrewAPicture
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: needs-patch
Focuses: Cc:

Description

Patch has docs for 'get_categories_taxonomy', 'get_tags' filters for wp-includes/category.php

Attachments (2)

25503-patch.diff (1.4 KB) - added by ben.moody 8 years ago.
25503-patch-v2.diff (1.5 KB) - added by ben.moody 8 years ago.

Download all attachments as: .zip

Change History (6)

#1 follow-up: @DrewAPicture
8 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to DrewAPicture
  • Status changed from new to reviewing

Hi, thanks for the patch. Looks pretty good, just a few little tweaks to do.

Some notes on 25503-patch.diff:

  • Short descriptions and parameter descriptions all need ending periods.
  • Parameter descriptions should start with a capital letter.
  • @since tags should use the 3-digit x.x.x version style
  • get_categories in the short description for the get_categories_taxonomy filter should have the parenthesis on it, get_categories().

#2 in reply to: ↑ 1 @ben.moody
8 years ago

Replying to DrewAPicture:

Hi, thanks for the patch. Looks pretty good, just a few little tweaks to do.

Some notes on 25503-patch.diff:

  • Short descriptions and parameter descriptions all need ending periods.
  • Parameter descriptions should start with a capital letter.
  • @since tags should use the 3-digit x.x.x version style
  • get_categories in the short description for the get_categories_taxonomy filter should have the parenthesis on it, get_categories().

Added an updated diff with suggested corrections. - 25503-patch-v2.diff

Thanks.

#3 @DrewAPicture
8 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 25724:

Inline documentation for hooks in wp-includes/category.php.

Props ben.moody
Fixes #25503.

#4 @DrewAPicture
8 years ago

  • Milestone changed from Awaiting Review to 3.7
Note: See TracTickets for help on using tickets.