#25504 closed defect (bug) (fixed)
Hook Docs: wp-includes/class-wp-image-editor.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Inline Docs | Keywords: | has-patch |
Focuses: | Cc: |
Description
Inline documentation for filters: 'wp_editor_set_quality' and 'image_editor_default_mime_type'
Attachments (3)
Change History (12)
#1
@
11 years ago
- Keywords has-patch added
- Owner set to DrewAPicture
- Status changed from new to reviewing
#2
@
11 years ago
- Milestone changed from Awaiting Review to 3.7
class-wp-image-editor.php.patch looks good to me. Thanks for the patch :)
#4
@
11 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Fixed the indentation for the PHP Docs.
#5
follow-up:
↓ 6
@
11 years ago
Thanks! Good to know for the next ones. So to be clear - the indentation is at the same level as the function doc block?
#6
in reply to:
↑ 5
@
11 years ago
Replying to tomauger:
Thanks! Good to know for the next ones. So to be clear - the indentation is at the same level as the function doc block?
No, 25504.docs.diff wasn't quite correct either.
It's tab indentation up to alignment with the entity, whether that be the filter, action or function declaration line, etc. The patch from @gayadesign was partially correct in that there should be a space before the *
in docblock lines. Note the spaces added in 25504.diff.
#8
follow-up:
↓ 9
@
11 years ago
Thanks for the additional clarifications. So my original indentation was correct, except that I was missing a space before the subsequent *s. I want to avoid making the same mistakes in the future.
#9
in reply to:
↑ 8
@
11 years ago
Replying to tomauger:
Thanks for the additional clarifications. So my original indentation was correct, except that I was missing a space before the subsequent *s. I want to avoid making the same mistakes in the future.
Yup, that was it. Thanks for the patches and the effort :)
Inline docs for filters