WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#25506 closed defect (bug) (fixed)

Twenty Twelve - single attachment page displays empty sidebar

Reported by: TomasM Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.5
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

From the code in the image.php we see that sidebar should not be loaded, but content is still narrow.

To fix this issue line 1457 in style.css:

	body.single-attachment .site-content,

should be replaced with:

	body.attachment .site-content,

Attachments (3)

25506.diff (458 bytes) - added by Marco_Teethgrinder 7 months ago.
25506.2.diff (871 bytes) - added by Marco_Teethgrinder 7 months ago.
Fixes for Twenty Thirteen and the IE stylesheet in Twenty Twelve.
25506.3.diff (879 bytes) - added by obenland 7 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 obenland7 months ago

  • Milestone changed from Awaiting Review to 3.8
  • Version changed from trunk to 3.5

Bug is valid. To recreate, view an image attachment that has a page as its parent.

Marco_Teethgrinder7 months ago

comment:2 Marco_Teethgrinder7 months ago

  • Keywords has-patch added; needs-patch removed

comment:3 nacin7 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25707:

Twenty Twelve: Use the correct body class for attachments.

.single-attachment is only used when the attachment's parent is not a page.

props Marco_Teethgrinder.
fixes #25506.

comment:4 follow-up: nacin7 months ago

  • Milestone changed from 3.8 to 3.7
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for Twenty Ten, Twenty Thirteen, and the IE stylesheet in Twenty Twelve.

comment:5 in reply to: ↑ 4 obenland7 months ago

Replying to nacin:

Reopening for Twenty Ten, Twenty Thirteen, and the IE stylesheet in Twenty Twelve.

Twenty Ten defines .single-attachment manually in its attachment.php file and uses a selector that is specific to the markup there. It does not necessarily need fixing.

Marco_Teethgrinder7 months ago

Fixes for Twenty Thirteen and the IE stylesheet in Twenty Twelve.

obenland7 months ago

comment:6 obenland7 months ago

Updated patch from Marco_Teethgrinder. We can remove the selector in Twenty Thirteen entirely since the right sidebar never gets loaded on image attachment pages.

comment:7 nacin7 months ago

In 25715:

Twenty Twelve: Use the correct body class for attachments in the IE stylesheet.

props Marco_Teethgrinder.
see #25506. see [25707].

comment:8 nacin7 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 25716:

Twenty Thirteen: Remove unneeded .single-attachment selector.

props obenland.
fixes #25506.

comment:9 lancewillett7 months ago

In 25737:

Twenty Fourteen: remove unneeded .single-attachment body class selectors, props iamtakashi. Fixes #25541, see #25506.

Note: See TracTickets for help on using tickets.