WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#25510 closed defect (bug) (fixed)

Hooks Docs: wp-includes/class-feed.php

Reported by: swissspidy Owned by: johnbillion
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch
Focuses: Cc:

Description

There's only 1 hook, so this will be a quick one.

Attachments (3)

25510.diff (1.1 KB) - added by swissspidy 8 years ago.
25510.2.diff (1.1 KB) - added by swissspidy 8 years ago.
25510.3.diff (805 bytes) - added by swissspidy 8 years ago.

Download all attachments as: .zip

Change History (11)

@swissspidy
8 years ago

#1 @swissspidy
8 years ago

  • Keywords has-patch added; needs-patch removed

#2 @johnbillion
8 years ago

  • Keywords needs-refresh added; has-patch removed

I think we should clarify that the lifetime parameter is the cache duration in seconds. The inline doc in 25510.diff suggests it might be in hours.

@swissspidy
8 years ago

#3 @swissspidy
8 years ago

  • Keywords has-patch added; needs-refresh removed

You're right. I just updated the doc block to make it more clear.

#4 @johnbillion
8 years ago

Good stuff!

Your latest patch is a patch of your first patch though. Can you provide a unified patch of both changes? Also you might want to remove those Git headers from your patch. See http://scribu.net/wordpress/svn-patches-from-git.html

@swissspidy
8 years ago

#5 @swissspidy
8 years ago

All good things go by three...

#6 @DrewAPicture
8 years ago

  • Owner set to johnbillion
  • Status changed from new to reviewing

#7 @DrewAPicture
8 years ago

  • Milestone changed from Awaiting Review to 3.7

#8 @DrewAPicture
8 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 25733:

Inline documentation for hooks in wp-includes/class-feed.php.

Props swissspidy.
Fixes #25510.

Note: See TracTickets for help on using tickets.