WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

#25515 closed defect (bug) (fixed)

Hooks Docs: wp-includes/class-wp-embed.php

Reported by: swissspidy Owned by: DrewAPicture
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch commit
Focuses: Cc:

Description

Inline docs for the WP_Embed class

Attachments (4)

25515.diff (2.7 KB) - added by swissspidy 6 months ago.
25515.2.diff (2.0 KB) - added by kpdesign 6 months ago.
Second pass
25515.3.diff (2.1 KB) - added by DrewAPicture 6 months ago.
Final.
25515.4.diff (3.3 KB) - added by DrewAPicture 6 months ago.

Download all attachments as: .zip

Change History (9)

swissspidy6 months ago

comment:1 swissspidy6 months ago

  • Keywords has-patch added; needs-patch removed

First attempt at hook documentation. Open for improvements.

comment:2 johnbillion6 months ago

One thing to mention here is that there's a duplicate filter in this file, so you can use the duplicate hook comment instead of documenting it twice. See http://make.wordpress.org/core/handbook/inline-documentation-standards/php-documentation-standards/#4-1-duplicate-hooks

comment:3 ocean906 months ago

Is this patch generated with or without --no-prefix, see this post?

kpdesign6 months ago

Second pass

DrewAPicture6 months ago

Final.

comment:4 DrewAPicture6 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.7

25515.4.diff works for me.

Last edited 6 months ago by DrewAPicture (previous) (diff)

DrewAPicture6 months ago

comment:5 DrewAPicture6 months ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 25726:

Inline documentation for hooks in wp-includes/class-wp-embed.php.

Props swissspidy, kpdesign.
Fixes #25515.

Note: See TracTickets for help on using tickets.