Make WordPress Core

Opened 2 years ago

Closed 5 days ago

#25520 closed defect (bug) (wontfix)

WP_Upgrader_Skin, error function should close div by calling footer

Reported by: aslam.sayyed Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.5.1
Component: Upgrade/Install Keywords: needs-patch
Focuses: Cc:


this generate invalid html markup document, in some case page layout getting disturbed.

function error($errors) {
	if ( ! $this->done_header )
	// need fix something like this
	if ( ! $this->done_header )

Change History (2)

comment:1 @dd322 years ago

I have a feeling this may have been rendered invalid by #25254

It might still be worth checking that header() / footer() are called consistently.

comment:2 @chriscct75 days ago

  • Keywords needs-patch added
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing as wontfix. Complete lack of interest on the ticket over the last 2 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch)

Note: See TracTickets for help on using tickets.