WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 5 months ago

#25520 new defect (bug)

WP_Upgrader_Skin, error function should close div by calling footer

Reported by: aslam.sayyed Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.5.1
Component: Upgrade/Install Keywords:
Focuses: Cc:

Description

this generate invalid html markup document, in some case page layout getting disturbed.

function error($errors) {
	if ( ! $this->done_header )
		$this->header();
	.... 
	// need fix something like this
	if ( ! $this->done_header )
		$this->footer();
}

Change History (1)

comment:1 dd325 months ago

I have a feeling this may have been rendered invalid by #25254

It might still be worth checking that header() / footer() are called consistently.

Note: See TracTickets for help on using tickets.