Opened 12 years ago
Closed 10 years ago
#25520 closed defect (bug) (wontfix)
WP_Upgrader_Skin, error function should close div by calling footer
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 3.5.1 |
| Component: | Upgrade/Install | Keywords: | needs-patch |
| Focuses: | Cc: |
Description
this generate invalid html markup document, in some case page layout getting disturbed.
function error($errors) {
if ( ! $this->done_header )
$this->header();
....
// need fix something like this
if ( ! $this->done_header )
$this->footer();
}
Change History (2)
#2
@
10 years ago
- Keywords needs-patch added
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from new to closed
Closing as wontfix. Complete lack of interest on the ticket over the last 2 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch)
Note: See
TracTickets for help on using
tickets.
I have a feeling this may have been rendered invalid by #25254
It might still be worth checking that header() / footer() are called consistently.