Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#25529 closed defect (bug) (fixed)

Smiley URL is not escaped within translate_smiley

Reported by:	simonwheatley	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	3.8
Component:	Formatting	Version:	2.8
Severity:	normal	Keywords:	has-patch dev-feedback commit
Cc:		Focuses:

Description

While documenting the hooks in formatting.php, #25518, I noticed that the URL used in the img element is not escaped.

Attachments (2)

25529.diff (653 bytes ) - added by simonwheatley 13 years ago.: Move esc_attr on $smiley closer to the output, use esc_url on the URL used for the src.
25529.tests.diff (982 bytes ) - added by simonwheatley 13 years ago.: Tests for translate_smiley escaping the URL (actually the right tests now)

Download all attachments as: .zip

Change History (7)

@simonwheatley
13 years ago

Attachment 25529.diff added

Move esc_attr on $smiley closer to the output, use esc_url on the URL used for the src.

@simonwheatley
13 years ago

Attachment 25529.tests.diff added

Tests for translate_smiley escaping the URL (actually the right tests now)

#1 @simonwheatley
13 years ago

Keywords dev-feedback added

#2 @GaryJ
13 years ago

Main patch looks good to me.

#3 @SergeyBiryukov
13 years ago

Keywords commit added
Milestone Awaiting Review → 3.8

25529.diff looks good to me. The unit test is probably not necessary here.

#4 @SergeyBiryukov
13 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

Escape smiley URL in translate_smiley().

props simonwheatley.
fixes #25529.

#5 @SergeyBiryukov
13 years ago

Update unit tests for convert_smilies(). see #25529.

Note: See TracTickets for help on using tickets.

Download in other formats: