![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 13 years ago
Closed 12 years ago
#25545 closed defect (bug) (fixed)
Invalidate post cache when a user is removed from a blog
| Reported by: | nprasath002 | Owned by: | wonderboymusic |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.9 |
| Component: | Cache API | Version: | 3.0 |
| Severity: | minor | Keywords: | has-patch |
| Cc: | Focuses: |
Description
In remove_user_from_blog invalidate post cache when a user is removed from a blog
Attachments (6)
Change History (17)
#5
@
12 years ago
Would array_walk( $post_ids, 'clean_post_cache' ); be more appropriate here than array_map(...), to make it clearer that we don't expect/need the return array?
#6
@
12 years ago
- Resolution fixed
- Status closed → reopened
- Version 3.6.1 → 3.0
In r27087 you're invalidating caches for all the existing posts of the receiving user. We really just need the ones that belong(ed) to the user being removed. Also this seems like a no-brainer for links as well and since they're still in core, let's clean those caches too. See 25545.3.diff.
#8
@
12 years ago
- Resolution fixed
- Status closed → reopened
Hi, sorry :) I'm having second thoughts about the INs in the queries in r27152, even though they're probably faster, they won't scale with large amounts of posts. Let's change those back. See 25545.4.diff.
Good catch, @nprasath002. I added a new patch here: 25545.diff