Make WordPress Core

Opened 10 years ago

Closed 4 years ago

Last modified 4 years ago

#25547 closed defect (bug) (worksforme)

”tag suggest box” does not disappear on ”inline edit”

Reported by: mt8biz's profile mt8.biz Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: Quick/Bulk Edit Keywords: has-patch
Focuses: Cc:

Description

reappearance:

1.begin ”inline edit”

2.show ”tag suggest”

3.push ENTER key to reflesh the artcle. (during focus on tag text area.)

patch:

tag suggest will disappear with onblur event on text area, and it gives focus to the save button.

Attachments (3)

inline-edit-post.js.diff (461 bytes) - added by mt8.biz 10 years ago.
25547.png (15.0 KB) - added by kraftner 10 years ago.
25547.patch (398 bytes) - added by kraftner 10 years ago.

Download all attachments as: .zip

Change History (28)

#1 @kraftner
10 years ago

Can you elaborate a bit more on what expected and actual behaviour is?

Do you want to cause pressing enter to choose the first "tag suggest" entry instead of saving? If yes I guess this is not intended behaviour. Press down arrow and then enter to do what you want.

#2 @kraftner
10 years ago

  • Keywords reporter-feedback added

#3 @mt8.biz
10 years ago

i know what happened to press ( arrow & enter ) key. ( for choose tag from suggest )

issue is "tag suggest" not disappeared.

please try it.

thank you.

http://mt8biz.files.wordpress.com/2013/10/tagsuggest.png

#4 @kraftner
10 years ago

Thanks, I can now reproduce this.

Steps to reproduce: Open "Quick Edit" -> start typing a tag -> without selecting a tag press enter to save

Expected behaviour: Suggestion-box disappears on save.
Actual behaviour: Suggestion-box stays visible on save. In my case it jumps to the top left corner.

#5 @kraftner
10 years ago

The suggested patch doesn't work for me.

@kraftner
10 years ago

#6 @kraftner
10 years ago

Tabbing out of the Tag-Textarea also leaves the input field visible, even if submitted. Now at standard position as on mt8.biz screenshot.

#7 @mt8.biz
10 years ago

it jumps to the top left corner

i didn't notice

thank you.

#8 @mt8.biz
10 years ago

On tab key ,

When selected any tag : "tag suggest" disappear and set to textarea.

When selected no tag : "tag suggest" keep appear.

@kraftner
10 years ago

#9 @kraftner
10 years ago

  • Keywords needs-testing added; reporter-feedback removed

#10 @kraftner
10 years ago

This fixes it for me.

The problem was that tab and enter did trigger a refresh on the suggest but due to the timeout-nature hiding the suggest due to blur was before showing it again because of the change to the element. I hope this makes sense.

Last edited 10 years ago by kraftner (previous) (diff)

#11 @mt8.biz
10 years ago

it works for me too.

thank you!

#12 @mt8.biz
10 years ago

  • Keywords dev-feedback added
  • Summary changed from canot delete ”tag suggest” on ”inline edit” to ”tag suggest box” dose not disappears on ”inline edit”

#13 @kraftner
10 years ago

Do you have problems with my patch? I do not really understand what your last comment/change implies.

#14 follow-up: @azaozz
10 years ago

Ideally this should use UI Autocomplete as it can be controlled better, has more options, is being actively developed and supported, etc. However adding it would probably make more sense as part of reworking the Quick Edit/Bulk Edit functionality. Many things can be improved and coded better there.

#15 @mt8.biz
10 years ago

I'm sorry in poor English.

There is no problem in your patch.

What I do I know the future now?

#16 @mt8.biz
10 years ago

  • Keywords dev-feedback removed

#17 @mt8.biz
10 years ago

I was tested 2 patterns. The patterns as below,

Test 1:

  • Open "Quick Edit".
  • Start Editing "Tags-Textarea". ( And Appear The "Tag-Suggests-Box" )
  • Press "Enter-Key" And Save The Post. ( And Disappear The Target Row of Table )

Result1 :

"Tag-Suggests-Box" Is Disappeared.

Test 2:

  • Open "Quick-Edit".
  • Start Editing "Tags-Textarea". ( And Appear The "Tag-Suggests-Box" )
  • Press "Tab-Key"And Focus Out "Tags-Textarea" .

Result2 :

"Tag-Suggests-Box" Is Disappeared.

patch filename : 25547.patch
version : trunk( revision:25781 )

#18 @mt8.biz
10 years ago

  • Keywords needs-testing removed

#19 @nacin
10 years ago

  • Component changed from Administration to Quick/Bulk Edit

#20 @chriscct7
8 years ago

  • Keywords needs-refresh added

#21 @SergeyBiryukov
7 years ago

  • Summary changed from ”tag suggest box” dose not disappears on ”inline edit” to ”tag suggest box” does not disappear on ”inline edit”

This ticket was mentioned in Slack in #core by noisysocks. View the logs.


4 years ago

#23 @talldanwp
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Hey @mt8biz, thanks for creating this ticket, it was discussed during a triage session in slack (https://wordpress.slack.com/archives/C02RQBWTW/p1594705348351800).

This was tested by a couple of individuals in 5.4.2.

In the intervening years since it was created this seems to have been resolved, so I'll close the ticket.

#24 @mt8.biz
4 years ago

Hi @talldanwp, I got it ! Thanks !

#25 in reply to: ↑ 14 @SergeyBiryukov
4 years ago

  • Keywords needs-refresh removed

Replying to azaozz:

Ideally this should use UI Autocomplete as it can be controlled better, has more options, is being actively developed and supported, etc.

Just noting that this happened in [38797] / #33902, which appears to have resolved this ticket too.

Note: See TracTickets for help on using tickets.