WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 2 months ago

#25547 new defect (bug)

”tag suggest box” dose not disappears on ”inline edit”

Reported by: mt8.biz Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.8
Component: Quick/Bulk Edit Keywords: has-patch
Focuses: Cc:

Description

reappearance:

1.begin ”inline edit”

2.show ”tag suggest”

3.push ENTER key to reflesh the artcle. (during focus on tag text area.)

patch:

tag suggest will disappear with onblur event on text area, and it gives focus to the save button.

Attachments (3)

inline-edit-post.js.diff (461 bytes) - added by mt8.biz 6 months ago.
25547.png (15.0 KB) - added by kraftner 6 months ago.
25547.patch (398 bytes) - added by kraftner 6 months ago.

Download all attachments as: .zip

Change History (22)

comment:1 kraftner6 months ago

Can you elaborate a bit more on what expected and actual behaviour is?

Do you want to cause pressing enter to choose the first "tag suggest" entry instead of saving? If yes I guess this is not intended behaviour. Press down arrow and then enter to do what you want.

comment:2 kraftner6 months ago

  • Keywords reporter-feedback added

comment:3 mt8.biz6 months ago

i know what happened to press ( arrow & enter ) key. ( for choose tag from suggest )

issue is "tag suggest" not disappeared.

please try it.

thank you.

http://mt8biz.files.wordpress.com/2013/10/tagsuggest.png

comment:4 kraftner6 months ago

Thanks, I can now reproduce this.

Steps to reproduce: Open "Quick Edit" -> start typing a tag -> without selecting a tag press enter to save

Expected behaviour: Suggestion-box disappears on save.
Actual behaviour: Suggestion-box stays visible on save. In my case it jumps to the top left corner.

comment:5 kraftner6 months ago

The suggested patch doesn't work for me.

kraftner6 months ago

comment:6 kraftner6 months ago

Tabbing out of the Tag-Textarea also leaves the input field visible, even if submitted. Now at standard position as on mt8.biz screenshot.

comment:7 mt8.biz6 months ago

it jumps to the top left corner

i didn't notice

thank you.

comment:8 mt8.biz6 months ago

On tab key ,

When selected any tag : "tag suggest" disappear and set to textarea.

When selected no tag : "tag suggest" keep appear.

kraftner6 months ago

comment:9 kraftner6 months ago

  • Keywords needs-testing added; reporter-feedback removed

comment:10 kraftner6 months ago

This fixes it for me.

The problem was that tab and enter did trigger a refresh on the suggest but due to the timeout-nature hiding the suggest due to blur was before showing it again because of the change to the element. I hope this makes sense.

Last edited 6 months ago by kraftner (previous) (diff)

comment:11 mt8.biz6 months ago

it works for me too.

thank you!

comment:12 mt8.biz6 months ago

  • Keywords dev-feedback added
  • Summary changed from canot delete ”tag suggest” on ”inline edit” to ”tag suggest box” dose not disappears on ”inline edit”

comment:13 kraftner6 months ago

Do you have problems with my patch? I do not really understand what your last comment/change implies.

comment:14 azaozz6 months ago

Ideally this should use UI Autocomplete as it can be controlled better, has more options, is being actively developed and supported, etc. However adding it would probably make more sense as part of reworking the Quick Edit/Bulk Edit functionality. Many things can be improved and coded better there.

comment:15 mt8.biz6 months ago

I'm sorry in poor English.

There is no problem in your patch.

What I do I know the future now?

comment:16 mt8.biz6 months ago

  • Keywords dev-feedback removed

comment:17 mt8.biz6 months ago

I was tested 2 patterns. The patterns as below,

Test 1:

  • Open "Quick Edit".
  • Start Editing "Tags-Textarea". ( And Appear The "Tag-Suggests-Box" )
  • Press "Enter-Key" And Save The Post. ( And Disappear The Target Row of Table )

Result1 :

"Tag-Suggests-Box" Is Disappeared.

Test 2:

  • Open "Quick-Edit".
  • Start Editing "Tags-Textarea". ( And Appear The "Tag-Suggests-Box" )
  • Press "Tab-Key"And Focus Out "Tags-Textarea" .

Result2 :

"Tag-Suggests-Box" Is Disappeared.

patch filename : 25547.patch
version : trunk( revision:25781 )

comment:18 mt8.biz6 months ago

  • Keywords needs-testing removed

comment:19 nacin2 months ago

  • Component changed from Administration to Quick/Bulk Edit
Note: See TracTickets for help on using tickets.