WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#25563 closed enhancement (wontfix)

Twenty Fourteen: Apply Custom Accent Colors to the Editor Styles

Reported by: celloexpressions Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Previously: #25220. We should apply the main custom accent color to a and ::selection / ::-moz-selection, and the accent_much_lighter color to a:hover, a:active (note: selection is not currently in editor-style.css, but I think it should be as it doesn't break anything and helps bring the character of the theme to the editor).

Because there's not a lot of css needed, we should do this by adding a <style> tag to the <head> in the TinyMCE iframe. I'll have a patch ready as soon as we can figure out the best way to add some code to the <head> of the TinyMCE iframe, but, as lancewillett said, it'll probably be hacky.

Attachments (1)

25563.DRAFT.diff (1.7 KB) - added by celloexpressions 7 years ago.
Apply the custom accent color to the TinyMCE editor. Need to determine an action to hook into for this, so patch won't work but is nearly code-complete.

Download all attachments as: .zip

Change History (6)

@celloexpressions
7 years ago

Apply the custom accent color to the TinyMCE editor. Need to determine an action to hook into for this, so patch won't work but is nearly code-complete.

#1 @lancewillett
7 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.8

#2 @celloexpressions
7 years ago

It might be worth adding a core hook for this if there isn't in fact one already. However, this is by all means an enhancement and not critical to the implementation of the custom accent color feature, so it's fine to leave this out if we can't work out a sane solution (ie, not worth considering this issue in evaluating the default-theme-worthiness of the custom accent color feature). Just something that, again, it would be nice to demonstrate how to do with the Customizer in a default theme.

#3 follow-up: @valeriosza
7 years ago

  • Keywords close added
  • Resolution set to maybelater
  • Status changed from new to closed

#4 in reply to: ↑ 3 @helen
7 years ago

  • Keywords close removed
  • Resolution maybelater deleted
  • Status changed from closed to reopened

Replying to valeriosza:

I'm seeing a flurry of odd Trac activity from you - did you mean to close this, and why?

#5 @lancewillett
7 years ago

  • Keywords has-patch removed
  • Milestone 3.8 deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed

I'd prefer we don't apply to editor styles. I think it not only adds more complexity than it's worth, but as you said -- not critical to the implementation of the Accent Color feature.

Note: See TracTickets for help on using tickets.