WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25565 closed enhancement (fixed)

Twenty Fourteen: Merge Front Page Sidebar and Content Sidebar

Reported by: iamtakashi Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords:
Focuses: Cc:
PR Number:

Description

Related: #25330

During the course of discussion regarding #25330, we've decided to merge those two sidebars. IRC log

Attachments (2)

25565.diff (26.7 KB) - added by iamtakashi 6 years ago.
25565.1.diff (932 bytes) - added by iamtakashi 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @iamtakashi
6 years ago

Here is the patch.

  • Merge Front Page Sidebar and Content Sidebar.
  • Rework widgets' and sidebars' style.

@iamtakashi
6 years ago

#2 @lancewillett
6 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.8

#3 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25762:

Twenty Fourteen: merge Front Page Sidebar and Content Sidebar. Props iamtakashi, see #25565; closes #25565.

#4 @lancewillett
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Leaving it open (didn't mean to close it yet) for testing and further comments.

@iamtakashi
6 years ago

#5 @iamtakashi
6 years ago

The patch above removes sidebar-ephemera.php which we don't need anymore.

#6 @lancewillett
6 years ago

In 25766:

Twenty Fourteen: remove unneeded sidebar file. Props iamtakashi, see #25565.

#7 @lancewillett
6 years ago

  • Keywords has-patch removed
  • Resolution set to fixed
  • Status changed from reopened to closed

Closing, open new tickets if problems arise.

Note: See TracTickets for help on using tickets.