Popular tags edit links do not respect current post type

[mordauk]

When a post type registers a non-hierarchical taxonomy, there is a "Popular Tags" section displayed on that taxonomies overview. Each of the terms included in the popular tags Tag Cloud is linked to an edit page for that term, but when clicking on the edit link, the current post type isn't respected, meaning the admin menu goes from having the current post type highlighted to having the standard Posts menu highlighted.

For example, the URL for the edit link of a popular "Download Tag" from my Easy Digital Downloads plugin is:

/wp-admin/edit-tags.php?action=edit&taxonomy=download_tag&tag_ID=6

Since &post_type=download is not included in the URL, the dashboard menu highlight changes to Posts.

To fix this, a couple of things are needed:

1. post_type needs to be passed as an argument to wp_tag_cloud() in wp-admin/edit-tags.php if the current user can edit the term.

2, The wp_tag_cloud() function should call get_edit_term_link() instead of get_edit_tag_link() when the link parameter is set to edit. The post_type arg passed should also be passed as the third parameter to get_edit_term_link(), for the object type.

[mordauk]

This is ready for further testing if anyone wants to tackle it.

[DrewAPicture]

25566.patch​ works as advertised for me. I also registered the taxonomy for multiple post types and both types the links respected the current post type.

Probably worth adding a short bit of documentation to the description about the new post_type parameter that wp_tag_cloud() accepts. We'll probably convert that section of the PHPDoc to a hash notation in the future but a small addition now should suffice.

[mordauk]

Refreshed patch with documentation for the post_type argument of wp_tag_cloud

[mordauk]

Updated patch attached with documentation for the post_type argument.

[DrewAPicture]

25566.2.patch​ looks good to me.

[fahmiadib]

Added unit test. review?

[wonderboymusic]

25566.diff​ combines the patches - the unit tests need some work.

[wonderboymusic]

25566.2.diff​ contains safer unit tests

[wonderboymusic]

In 27720:

Popular tags' edit links should respect the current post type. Adds unit test.

Props mordauk, fahmiadib.
Fixes #25566.

[boonebgorges]

In 35987:

More focused test for post_type in tag cloud links.

We should not be testing the entire tag cloud markup, as it leads to collateral
damage wheneven wp_generate_tag_cloud() is touched. See [35984].

See #25566, #35138.