Popular tags edit links do not respect current post type
|Reported by:||mordauk||Owned by:||wonderboymusic|
|Component:||Taxonomy||Keywords:||has-patch wcorl needs-testing|
When a post type registers a non-hierarchical taxonomy, there is a "Popular Tags" section displayed on that taxonomies overview. Each of the terms included in the popular tags Tag Cloud is linked to an edit page for that term, but when clicking on the edit link, the current post type isn't respected, meaning the admin menu goes from having the current post type highlighted to having the standard Posts menu highlighted.
For example, the URL for the edit link of a popular "Download Tag" from my Easy Digital Downloads plugin is:
Since &post_type=download is not included in the URL, the dashboard menu highlight changes to Posts.
To fix this, a couple of things are needed:
- post_type needs to be passed as an argument to wp_tag_cloud() in wp-admin/edit-tags.php if the current user can edit the term.
2, The wp_tag_cloud() function should call get_edit_term_link() instead of get_edit_tag_link() when the link parameter is set to edit. The post_type arg passed should also be passed as the third parameter to get_edit_term_link(), for the object type.