3.7-beta2-25760 - warning message on update-core.php

[harmr]

I use 3.7-beta2-25760 and when I go to Dashboard / Updates, I get the following error message below "An updated version of WordPress is available.":

Warning: is_dir(): open_basedir restriction in effect. File(/home/htdocs/.svn) is not within the allowed path(s): (/var/cache/liveconfig/installer/:/tmp/:/home/htdocs/) in /home/htdocs/html/wp-admin/includes/class-wp-upgrader.php on line 1510
Warning: is_dir(): open_basedir restriction in effect. File(/home/.svn) is not within the allowed path(s): (/var/cache/liveconfig/installer/:/tmp/:/home/htdocs/) in /home/htdocs/html/wp-admin/includes/class-wp-upgrader.php on line 1510
Warning: is_dir(): open_basedir restriction in effect. File(/home/htdocs/.git) is not within the allowed path(s): (/var/cache/liveconfig/installer/:/tmp/:/home/htdocs/) in /home/htdocs/html/wp-admin/includes/class-wp-upgrader.php on line 1510
Warning: is_dir(): open_basedir restriction in effect. File(/home/.git) is not within the allowed path(s): (/var/cache/liveconfig/installer/:/tmp/:/home/htdocs/) in /home/htdocs/html/wp-admin/includes/class-wp-upgrader.php on line 1510
Warning: is_dir(): open_basedir restriction in effect. File(/home/htdocs/.hg) is not within the allowed path(s): (/var/cache/liveconfig/installer/:/tmp/:/home/htdocs/) in /home/htdocs/html/wp-admin/includes/class-wp-upgrader.php on line 1510
Warning: is_dir(): open_basedir restriction in effect. File(/home/.hg) is not within the allowed path(s): (/var/cache/liveconfig/installer/:/tmp/:/home/htdocs/) in /home/htdocs/html/wp-admin/includes/class-wp-upgrader.php on line 1510
Warning: is_dir(): open_basedir restriction in effect. File(/home/htdocs/.bzr) is not within the allowed path(s): (/var/cache/liveconfig/installer/:/tmp/:/home/htdocs/) in /home/htdocs/html/wp-admin/includes/class-wp-upgrader.php on line 1510
Warning: is_dir(): open_basedir restriction in effect. File(/home/.bzr) is not within the allowed path(s): (/var/cache/liveconfig/installer/:/tmp/:/home/htdocs/) in /home/htdocs/html/wp-admin/includes/class-wp-upgrader.php on line 1510

The automatic updates works though.

[markoheijnen]

Closing this as duplicate of #22704. The issue is already mentioned there.

[nacin]

Reopening this, as #22704 is a behemoth. It's good to have individual bug reports separate from task tickets.

[nacin]

Four possible patches.

1. 25572.diff​ actually tries to catch is_dir() warnings. The ini_set('open_basedir', '/Users/nacin/Sites/develop/build/'); line is debug code. Only tested for open_basedir, not safe_mode.

2. 25572.2.diff​ simply @'s is_dir().

3. 25572.3.diff​ @'s the main dir we're checking (inside of which we're looking for .svn, etc.) and breaks if we can't access it. A continue isn't needed as the next directory is only going to be further up. Leaning toward this one even though it would be an extra directory call.

4. But at this point we could switch to scandir(), since we need to check inside each directory for 4 directories anyway. So, that'd be 25572.4.diff​. but I don't actually know how performant that'd be, especially if directories above us are large.

[nacin]

Going with 2.diff. It's without a doubt the most flexible option. 1.diff handles only one possible issue with is_dir() failing. 3.diff optimizes for bailing early on a possible open_basedir restriction, but at the expense of an extra is_dir() call. In 4.diff, scandir() could return who knows how many files, especially as we venture up

[nacin]

In 25764:

Silence possible warnings from is_dir(). fixes #25572.